fix: build BatchRequestItem urls relative to the API version

[Max Azatian (HardMax71)]

Overview

Fixes #1116. BatchRequestItem built from a RequestInformation kept the full https://graph.microsoft.com/v1.0/... URL, so the serialized $batch body carried absolute URLs. set_url() is meant to strip the version, but API_VERSION_REGEX = re.compile(r'/\/(v1.0|beta)/') reads as a JavaScript regex literal ported as-is: in Python both / and \/ are literal slashes, so it only ever matched //v1.0/.

Three lines: the regex is now r'/(v1\.0|beta)(?=/|$)' (matches the version as a whole path segment, so /sites/beta-site is left alone), ME_TOKEN_REGEX gets the same treatment, and the constructor goes through set_url(), which already handles the me-token, query string and fragment. The result matches what the JavaScript SDK does in BatchRequestContent.ts (it strips scheme, host and version, and its tests expect /me/drive/root/children).

Notes

The existing tests pinned the old behaviour (url == base_url after construction, "/v1.0/me" after set_url), so those assertions changed to the relative form. Anyone who read item.url back and stripped the version themselves, as we did, gets an already relative URL now; the batch body they send does not change. Open PRs #711 and #996 touch serialize() in the same file, not these lines.

Testing Instructions

• pip install -r requirements-dev.txt, then pytest tests/requests/test_batch_request_item.py: 3 new cases (beta URL with query and fragment, an already relative path, a version-like segment inside the path), 7 updated ones.
• Full suite: 77 passed. yapf -dr src, mypy src and pylint src --disable=W --rcfile=.pylintrc clean.
• Before/after on a POST .../v1.0/users/u1/messages/m1/move item: the serialized body's url goes from the absolute URL to /users/u1/messages/m1/move.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Max Azatian (HardMax71)]

Max Azatian (Max Azatian (@HardMax71)) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

[Max Azatian (HardMax71)]

Any chance this gets a review? The workflows on this PR are still waiting for approval, so Build and test has not run here; locally the full suite passes on the PR head. The branch is two workflow-only commits behind main and merges cleanly, and I can rebase if you prefer.

Still reproduces on 1.5.1 with msgraph-sdk 1.63.0. It is easy to miss: a fresh request builder gives a relative URL, and the absolute one only appears after a request has been sent through the same builder chain, because the adapter writes baseurl into the shared path parameters.

repro

# pip install msgraph-sdk==1.63.0 Deprecated   (Deprecated is the missing dependency from #1030)
import asyncio
from importlib.metadata import version

import httpx
from kiota_abstractions.authentication import AnonymousAuthenticationProvider
from msgraph import GraphRequestAdapter, GraphServiceClient
from msgraph.generated.users.item.messages.item.move.move_post_request_body import MovePostRequestBody
from msgraph_core import GraphClientFactory
from msgraph_core.requests.batch_request_item import BatchRequestItem


async def main():
    print("msgraph-core", version("msgraph-core"), "msgraph-sdk", version("msgraph-sdk"))
    transport = httpx.MockTransport(lambda request: httpx.Response(200, json={"value": []}))
    http = GraphClientFactory.create_with_default_middleware(client=httpx.AsyncClient(transport=transport))
    client = GraphServiceClient(request_adapter=GraphRequestAdapter(AnonymousAuthenticationProvider(), client=http))
    user = client.users.by_user_id("u1")

    def item_url():
        info = user.messages.by_message_id("m1").move.to_post_request_information(MovePostRequestBody(destination_id="f1"))
        return BatchRequestItem(request_information=info, id="m1").url

    print("before any request:", item_url())
    await user.messages.get()
    print("after user.messages.get():", item_url())


asyncio.run(main())

1.5.1:

before any request: /users/u1/messages/m1/move
after user.messages.get(): https://graph.microsoft.com/v1.0/users/u1/messages/m1/move

this PR:

before any request: /users/u1/messages/m1/move
after user.messages.get(): /users/u1/messages/m1/move