Repository navigation
Add a more complete option to set the fields of a sockaddr with a more complex network address string - #673
Open
Keith Horton (keith-horton) wants to merge 2 commits into
Conversation
Parse IPv4 and IPv6 addresses with optional ports and scope IDs. Cover ANSI and Unicode throwing and nothrow overloads, reset behavior, formatting round-trips, and invalid inputs. Store IPv6 scope IDs in host byte order to match native Windows APIs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5fc64de7-6803-4598-8ede-edf4a27aa737
- network.h: value-initialize the SOCKADDR_INET union member. Clang's
'm_sockaddr{}' only zero-initialized the first union member (SOCKADDR_IN),
leaving bytes 16-27 uninitialized, which failed the reset_complete_address
failure-path memcmp test in the clang CI jobs.
- NetworkTests: add Verifying_byte_order_with_os_apis, validating port and
IPv6 scope id byte-order against RtlIpv4/Ipv6StringToAddressExW,
RtlIpv4/Ipv6AddressToStringExW, GetUnicastIpAddressTable,
GetAdaptersAddresses, and binding to link-local addresses with the
host-byte-order (succeeds) vs network-byte-order (fails) scope id.
- NetworkTests: add an inbound Windows Firewall rule (INetFwPolicy2) for the
test executable while socket tests run, to prevent the firewall prompt;
warns and continues when not elevated.
- Link iphlpapi.lib for the tests; document elevation in README.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b4a8161d-23a4-4145-9937-0fc0ca9a43a3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The naming matches the existing "
Validation
Networking tests passed in normal and noexcept builds (2697 and 1759 assertions respectively).