Repository navigation
sessions: use compare icon for model comparisons - #342960
Merged
Megan Rogge (meganrogge) merged 1 commit intoOct 20, 2026
Merged
Conversation
Use the balance-scales codicon from microsoft/vscode-codicons#540 for the comparison toggle and composer, preserving accessible labels and toggle state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ross Wollman (rwoll)
approved these changes
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped icon replacement preserves existing behavior and has no unresolved defects.
No open issues 🎉
What changed in this PR
Replaces trophy icons with the balance-scales compare icon for model comparisons in the Agents window.
Changes:
- Registers the compare glyph through the derived codicons mapping.
- Updates the comparison toggle and composer icons without changing interaction behavior.
- Updates icon assertions while preserving accessibility and toggle-state checks.
No actionable findings remain. Reported validation was not rerun.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/input/modelPicker/modelPickerTabbedWidget.test.ts | Updates comparison toggle icon assertions. |
| src/vs/workbench/contrib/chat/test/browser/widget/input/modelPicker/modelPickerActionItem.test.ts | Updates composer icon assertions and test names. |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerWidget.ts | Uses the compare icon in the composer. |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerTabbedWidget.ts | Uses the compare icon for the toggle. |
| src/vs/base/common/codicons.ts | Registers the compare glyph. |
Review effort: Balanced
Contributor
Screenshot ChangesBase: Changed (6)
|
| Before | After |
|---|---|
 |
 |
sessions/compareModels/sessionComparisonModelPicker/FolderlessAttempts/Light
| Before | After |
|---|---|
 |
 |
sessions/compareModels/sessionComparisonModelPicker/NoAttemptsSelected/Light
| Before | After |
|---|---|
 |
 |
sessions/compareModels/sessionComparisonModelPicker/AttemptsSelected/Light
| Before | After |
|---|---|
 |
 |
sessions/compareModels/sessionComparisonModelPicker/JudgeSelected/Light
| Before | After |
|---|---|
 |
 |
sessions/compareModels/sessionComparisonModelPicker/SynthesizerSelected/Light
| Before | After |
|---|---|
 |
 |
Megan Rogge (meganrogge)
deleted the
agents/compare-agents-icon-integration
branch
October 20, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the balance-scales compare icon introduced in microsoft/vscode-codicons#540 instead of the trophy for the Compare Models toggle and configured comparison composer in the Agents window.
Register the glyph through the existing derived codicons mapping without editing the generated library. The existing @vscode/codicons 0.0.46-47 dependency already includes the glyph, so no dependency change is needed. Preserve accessible labels, toggle state, keyboard behavior, and feature gating.
Validation
npm run compile— passed (client and built-in extensions)../scripts/test.sh --reporter dot --run src/vs/workbench/contrib/chat/test/browser/widget/input/modelPicker/modelPickerActionItem.test.ts --run src/vs/workbench/contrib/chat/test/browser/widget/input/modelPicker/modelPickerTabbedWidget.test.ts— passed, 159 tests.npm run eslint -- src/vs/base/common/codicons.ts src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerTabbedWidget.ts src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerWidget.ts src/vs/workbench/contrib/chat/test/browser/widget/input/modelPicker/modelPickerTabbedWidget.test.ts src/vs/workbench/contrib/chat/test/browser/widget/input/modelPicker/modelPickerActionItem.test.ts— passed.--agents; visually verified the balance-scales glyph in the picker and composer, selected two models, and committed the comparison with Done. No prompt was sent.How to Test
sessions.chat.compareAgents.enabled).