Repository navigation
[cherry-pick] chat: use trophy icon for model comparison toggle - #342710
Merged
Megan Rogge (meganrogge) merged 5 commits intoOct 19, 2026
Merged
Conversation
Update Codicons to 0.0.46-46 and register the trophy glyph added in microsoft/vscode-codicons#539. Preserve the comparison toggle's accessible label and pressed-state behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the existing active input-option colors and border for the trophy toggle while preserving its dimensions and accessible pressed state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the composer's per-attempt provider icons with the comparison trophy. Preserve committed model details in the hover and accessible label across expanded, compact, and minimal layouts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5f2f1f6e-e1d6-4baa-a0ac-d60c48f5edd2
Kyle Cutler (kycutler)
approved these changes
Oct 19, 2026
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
sessions/compareModels/sessionComparisonModelPicker/AttemptsSelected/Light
| Before | After |
|---|---|
 |
 |
sessions/compareModels/sessionComparisonModelPicker/JudgeSelected/Light
| Before | After |
|---|---|
 |
 |
sessions/compareModels/sessionComparisonModelPicker/SynthesizerSelected/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped presentation changes have focused regression coverage and no identified blocking defects.
No open issues 🎉
1 file not reviewed
remote/web/package-lock.json: Generated file
What changed in this PR
Ports the model-comparison trophy presentation to the release branch while preserving comparison behavior and accessibility.
Changes:
- Update Codicons dependencies and register the trophy glyph.
- Use a single trophy for comparisons, with persistent selected-state styling.
- Remove obsolete per-attempt icon support and extend regression coverage.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/input/modelPicker/modelPickerTabbedWidget.test.ts | Verify trophy, pressed state, colors, and dimensions. |
| src/vs/workbench/contrib/chat/test/browser/widget/input/modelPicker/modelPickerActionItem.test.ts | Cover single-trophy rendering, accessibility, and reset. |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerWidget.ts | Render one trophy for configured comparisons. |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerTabbedWidget.ts | Use trophy for the comparison toggle. |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerComparison.ts | Remove obsolete icon presentation contract. |
| src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/media/modelPicker.css | Style selected toggle; remove obsolete icon-row styling. |
| src/vs/sessions/contrib/chat/browser/sessionComparisonModelSelection.ts | Remove unused summary model IDs. |
| src/vs/base/common/codiconsLibrary.ts | Register trophy glyph. |
| remote/web/package.json | Update web Codicons dependency. |
| remote/web/package-lock.json | Lock updated web Codicons package. |
| package.json | Update root Codicons dependency. |
| package-lock.json | Lock updated root Codicons package. |
Review effort: Balanced
Megan Rogge (meganrogge)
merged commit Oct 19, 2026
bd48520
into
release/1.143
89 of 90 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #342688 to release/1.143.
Summary
Winner displays and metric badges are unchanged. The existing copy-codicons build task supplies the updated font.
Release branch adaptation
The production changes cherry-picked cleanly. release/1.143 does not contain newer main-only model picker tests that the first two source commits modified, so the equivalent trophy, accessible pressed-state, selected theme colors, and stable-dimension assertions were added to the release branch's existing comprehensive comparison picker test. The adapted assertion re-queries the live action after toggling because the release picker replaces that DOM node when entering comparison setup.
Validation
Manual test
With model comparison enabled in the Agents window, open the new-session model picker. Confirm the trophy appears beside Search. Activate it and verify the selected fill and border remain visible after moving the pointer away, aria-pressed is true, and the control does not shift size. Configure multiple attempts and confirm the composer shows exactly one trophy while hover and accessible text still list the configured models and variants. Activate the trophy to edit the comparison, then reset the comparison and confirm the normal model label returns.