Repository navigation
[http-client-java] Preserve page-size overrides in typed async paging - #12163
Open
Xiaofei Cao (XiaofeiCao) wants to merge 5 commits into
Open
Xiaofei Cao (XiaofeiCao) wants to merge 5 commits into
Xiaofei Cao (XiaofeiCao) wants to merge 5 commits into
Conversation
Fixes microsoft#12149 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
emitter:client:java
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation covers initial and continuation requests, preserves default behavior, and includes targeted regression coverage.
0 open findings
What changed in this PR
Fixes typed async paging so byPage(size) forwards page-size overrides through initial and continuation requests.
Changes:
- Updates the async convenience-method generator.
- Regenerates the pageable async client.
- Adds Spector regression coverage and a fix changelog.
| File | Description |
|---|---|
ConvenienceAsyncMethodTemplate.java |
Forwards optional page size in generated adapters. |
PageableAsyncClient.java |
Regenerates the corrected client. |
PageableTests.java |
Verifies async page sizes and returned users. |
.chronus/changes/http-client-java-async-page-size.md |
Records the bug fix. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Weidong Xu (weidongxu-microsoft)
approved these changes
Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12149.
Summary
PagedFlux, including continuation requests, while preserving default paging when no size is specified.PageableTestswith async Spector coverage usingbyPage(3), verifying page sizes[3, 1]and usersuser5throughuser8. No new test classes or mock API scenarios are included.Validation
Expected query param maxpagesize=3 but got undefined.PageableTestspass against the existing Spector mock API after a clean compilation.