Skip to content

tailor: build dependsOn prerequisites when selecting a consumer - #965

Open
Paco Huelsz (frhuelsz) wants to merge 1 commit into
mainfrom
user/frhuelsz/tailor-dependson-prerequisites
Open

Paco Huelsz (frhuelsz) wants to merge 1 commit into
mainfrom
user/frhuelsz/tailor-dependson-prerequisites

Conversation

@frhuelsz

Copy link
Copy Markdown
Collaborator

Building only a consumer currently schedules zero cells for dependencies declared solely through dependsOn.

Schedule their enabled cells without the consumer’s axis/slug filters, including transitive prerequisites. Keep fragment skips, deduplicate shared cells, and include prerequisite signing in preflight. Order-only outputs still do not enter the consumer fingerprint.

Added scheduling/signing regressions; cd tools/tailor && just check passes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@frhuelsz
Paco Huelsz (frhuelsz) requested a review from a team as a code owner November 19, 2026 02:10
Copilot AI balanced review requested due to automatic review settings November 19, 2026 02:10
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block approval of the prerequisite-scheduling change.

No open issues 🎉

What changed in this PR

Fixes Tailor’s consumer-only builds so dependsOn prerequisites are scheduled rather than omitted, while preserving their order-only fingerprint behavior.

Changes:

  • Schedules enabled prerequisite cells, including transitive dependencies, independently of consumer filters while respecting fragment skips.
  • Includes scheduled prerequisites in signing preflight.
  • Adds scheduling and signing regression tests and documents the selection behavior.
File Description
tools/​tailor/​docs/​reference/​image-yaml.md Documents prerequisite selection and fragment-skip behavior.
tools/​tailor/​crates/​tailor/​tests/​cli.rs Adds regressions for transitive scheduling, deduplication, signing, and input-producer prerequisites.
tools/​tailor/​crates/​tailor/​src/​run.rs Tracks scheduled targets for signing preflight.
tools/​tailor/​crates/​tailor-core/​src/​imagedep.rs Includes enabled dependsOn cells in required producers and tests fragment skips.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants