Repository navigation
tailor: build dependsOn prerequisites when selecting a consumer - #965
Open
Paco Huelsz (frhuelsz) wants to merge 1 commit into
Open
Paco Huelsz (frhuelsz) wants to merge 1 commit into
Paco Huelsz (frhuelsz) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the prerequisite-scheduling change.
No open issues 🎉
What changed in this PR
Fixes Tailor’s consumer-only builds so dependsOn prerequisites are scheduled rather than omitted, while preserving their order-only fingerprint behavior.
Changes:
- Schedules enabled prerequisite cells, including transitive dependencies, independently of consumer filters while respecting fragment skips.
- Includes scheduled prerequisites in signing preflight.
- Adds scheduling and signing regression tests and documents the selection behavior.
| File | Description |
|---|---|
tools/tailor/docs/reference/image-yaml.md |
Documents prerequisite selection and fragment-skip behavior. |
tools/tailor/crates/tailor/tests/cli.rs |
Adds regressions for transitive scheduling, deduplication, signing, and input-producer prerequisites. |
tools/tailor/crates/tailor/src/run.rs |
Tracks scheduled targets for signing preflight. |
tools/tailor/crates/tailor-core/src/imagedep.rs |
Includes enabled dependsOn cells in required producers and tests fragment skips. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building only a consumer currently schedules zero cells for dependencies declared solely through
dependsOn.Schedule their enabled cells without the consumer’s axis/slug filters, including transitive prerequisites. Keep fragment skips, deduplicate shared cells, and include prerequisite signing in preflight. Order-only outputs still do not enter the consumer fingerprint.
Added scheduling/signing regressions;
cd tools/tailor && just checkpasses.