Repository navigation
fix: ignore saved noTransition when rolling back - #960
Open
bfjelds (bfjelds) wants to merge 1 commit into
Open
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 631b5a4c-55cd-4c59-8107-7d013238c0da
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the change ensuring finalized A/B rollbacks report that a reboot is required.
No open issues 🎉
What changed in this PR
Ensures finalized A/B rollbacks report that a reboot is required, regardless of a noTransition override saved in the restored configuration. Caller-managed reboot policy remains unchanged.
Changes:
- Returns
ExitKind::NeedsRebootunconditionally after A/B rollback finalization. - Removes the obsolete override check, warning, and unused imports.
| File | Description |
|---|---|
crates/trident/src/engine/manual_rollback/mod.rs |
Prevents saved noTransition settings from suppressing the rollback’s reboot requirement. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For CLI, always report that a reboot is required after finalizing A/B rollback, regardless of
internalParams.noTransitionin the restored configuration. It seems quite odd to respect noTransition for another operation's (the previous update) host configuration.Rationale
An override saved by an earlier operation must not control a later rollback. Preserve the existing gRPC
CALLER_HANDLES_REBOOTpolicy: callers can still perform the reboot themselves. Runtime rollback and update behavior are unchanged.Validation
scripts/cloud-agent/validate.shscripts/cloud-agent/validate.sh rustscripts/cloud-agent/validate.sh go-vet=off.scripts/cloud-agent/validate.sh tailorInitial full-suite and Rust retries failed because of missing package-feed credentials and Make's relative
targetpath. Both environment issues were resolved without source changes; the final complete suite passed. VM-only Rust functional tests were not executed on the host.