Skip to content

fix: ignore saved noTransition when rolling back - #960

Open
bfjelds (bfjelds) wants to merge 1 commit into
mainfrom
user/bfjelds/rollback-ignore-inherited-no-transition
Open

bfjelds (bfjelds) wants to merge 1 commit into
mainfrom
user/bfjelds/rollback-ignore-inherited-no-transition

Conversation

@bfjelds

@bfjelds bfjelds (bfjelds) commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Description

For CLI, always report that a reboot is required after finalizing A/B rollback, regardless of internalParams.noTransition in the restored configuration. It seems quite odd to respect noTransition for another operation's (the previous update) host configuration.

Rationale

An override saved by an earlier operation must not control a later rollback. Preserve the existing gRPC CALLER_HANDLES_REBOOT policy: callers can still perform the reboot themselves. Runtime rollback and update behavior are unchanged.

Validation

Source Command or check Result Notes
Agent scripts/cloud-agent/validate.sh Passed Complete format, Rust, Go and Tailor suite at this revision.
Agent scripts/cloud-agent/validate.sh rust Passed Workspace checks, strict Clippy, API schema and unit/doc tests, including caller-/daemon-owned reboot handling.
Agent scripts/cloud-agent/validate.sh go Passed Both Go modules; installer uses the script's existing -vet=off.
Agent scripts/cloud-agent/validate.sh tailor Passed Formatting, strict Clippy and workspace tests.
Agent VM rollback lifecycle Not run No VM lifecycle result is claimed.

Initial full-suite and Rust retries failed because of missing package-feed credentials and Make's relative target path. Both environment issues were resolved without source changes; the final complete suite passed. VM-only Rust functional tests were not executed on the host.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 631b5a4c-55cd-4c59-8107-7d013238c0da
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@bfjelds
bfjelds (bfjelds) marked this pull request as ready for review November 18, 2026 04:45
@bfjelds
bfjelds (bfjelds) requested a review from a team as a code owner November 18, 2026 04:45
Copilot AI balanced review requested due to automatic review settings November 18, 2026 04:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the change ensuring finalized A/B rollbacks report that a reboot is required.

No open issues 🎉

What changed in this PR

Ensures finalized A/B rollbacks report that a reboot is required, regardless of a noTransition override saved in the restored configuration. Caller-managed reboot policy remains unchanged.

Changes:

  • Returns ExitKind::NeedsReboot unconditionally after A/B rollback finalization.
  • Removes the obsolete override check, warning, and unused imports.
File Description
crates/​trident/​src/​engine/​manual_rollback/​mod.rs Prevents saved noTransition settings from suppressing the rollback’s reboot requirement.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants