Repository navigation
refactor: move GRUB into subsystems - #959
Draft
Paco Huelsz (frhuelsz) wants to merge 1 commit into
Draft
Paco Huelsz (frhuelsz) wants to merge 1 commit into
Paco Huelsz (frhuelsz) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the GRUB subsystem refactor.
No open issues 🎉
What changed in this PR
Moves GRUB-specific configuration into the subsystem layer while keeping shared UKI and ESP naming helpers in engine::boot.
Changes:
- Renames
BootSubsystemtoGrubSubsystemand updates its registration, logging, and tracing names. - Relocates GRUB configuration and functional-test fixtures under
subsystems/grub. - Adjusts imports and root-device helper visibility to support the new module location.
| File | Description |
|---|---|
crates/trident/src/subsystems/mod.rs |
Registers the GRUB module. |
crates/trident/src/subsystems/grub/test_files/grub_esp.cfg |
Relocates the ESP GRUB fixture. |
crates/trident/src/subsystems/grub/test_files/grub_boot.cfg |
Relocates the boot GRUB fixture. |
crates/trident/src/subsystems/grub/mod.rs |
Defines GrubSubsystem, preserving UKI and stream-image skips. |
crates/trident/src/subsystems/grub/config.rs |
Relocates GRUB configuration logic and updates imports. |
crates/trident/src/engine/mod.rs |
Registers GrubSubsystem in place of BootSubsystem. |
crates/trident/src/engine/context/mod.rs |
Makes root-device lookup accessible across the crate. |
crates/trident/src/engine/boot/mod.rs |
Removes the GRUB subsystem while retaining shared boot helpers. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BootSubsystemtoGrubSubsystemsubsystems/grubengine::bootValidation