Skip to content

refactor: move GRUB into subsystems - #959

Draft
Paco Huelsz (frhuelsz) wants to merge 1 commit into
mainfrom
user/frhuelsz/prototype-grub-subsystem-move
Draft

Paco Huelsz (frhuelsz) wants to merge 1 commit into
mainfrom
user/frhuelsz/prototype-grub-subsystem-move

Conversation

@frhuelsz

Copy link
Copy Markdown
Collaborator

Summary

  • rename BootSubsystem to GrubSubsystem
  • move GRUB configuration and functional-test fixtures under subsystems/grub
  • keep shared UKI and ESP naming helpers in engine::boot

Validation

  • 482 Trident unit tests
  • functional-test all-target check
  • functional-test manifest generation
  • clippy

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the GRUB subsystem refactor.

No open issues 🎉

What changed in this PR

Moves GRUB-specific configuration into the subsystem layer while keeping shared UKI and ESP naming helpers in engine::boot.

Changes:

  • Renames BootSubsystem to GrubSubsystem and updates its registration, logging, and tracing names.
  • Relocates GRUB configuration and functional-test fixtures under subsystems/grub.
  • Adjusts imports and root-device helper visibility to support the new module location.
File Description
crates/​trident/​src/​subsystems/​mod.rs Registers the GRUB module.
crates/​trident/​src/​subsystems/​grub/​test_files/​grub_esp.cfg Relocates the ESP GRUB fixture.
crates/​trident/​src/​subsystems/​grub/​test_files/​grub_boot.cfg Relocates the boot GRUB fixture.
crates/​trident/​src/​subsystems/​grub/​mod.rs Defines GrubSubsystem, preserving UKI and stream-image skips.
crates/​trident/​src/​subsystems/​grub/​config.rs Relocates GRUB configuration logic and updates imports.
crates/​trident/​src/​engine/​mod.rs Registers GrubSubsystem in place of BootSubsystem.
crates/​trident/​src/​engine/​context/​mod.rs Makes root-device lookup accessible across the crate.
crates/​trident/​src/​engine/​boot/​mod.rs Removes the GRUB subsystem while retaining shared boot helpers.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants