You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feature: Add Trident Linux Installer for ISO autorun - #819
Adds trident-installer, an optional RPM for installer ISOs. It runs Trident with a terminal UI for installation progress, logs, and recovery.
Starts automatically when the ISO boots with trident.installer=1.
Installs using a supplied Host Configuration, or streams the first COSI found on the installer media. There is no initial source picker or confirmation prompt.
Shows progress on the local console and sends logs to serial consoles. Recovery offers a shell or a new installation from a remote URL.
Includes TOML configuration and an installer reference covering setup, source selection, and screen flows.
Remove the installer media after installation: leaving it first in boot order can reimage the machine on the next boot.
🤔 Rationale
Give installer ISOs a small Rust front end to Trident instead of maintaining separate shell installers.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Unresolved critical issues could let changed image metadata make an excluded installer USB eligible as the installation target, while new dependencies remain missing from the packaged license notices.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Blocking serial writes can freeze the installer indefinitely, and the service dependencies still activate on normal boots despite the kernel-command-line condition.
Prevent blocked serial writes from freezing the installer loop
crates/installer/src/main.rs:115
Serial mirrors are opened in blocking mode, and Output::announce in ui.rs:724–737 writes to them synchronously in the installer event loop. If serial output stalls under flow control, the write can block indefinitely, freezing recovery input, progress consumption, and automatic reboot. Open the mirrors nonblocking through an osutils helper and drop a mirror on backpressure, or use a bounded background writer so serial logging cannot stall the installer.
Gate installer dependencies to installer boots
packaging/systemd/trident-installer.service:5
The kernel-command-line condition does not gate these dependency jobs. Because the RPM installs a multi-user.target.wants symlink, an unmarked normal boot still starts tridentd.socket and systemd-udev-settle.service before skipping the installer, reactivating an otherwise disabled socket and introducing a udev-settle boot wait. Gate inclusion in the boot transaction itself, for example with a marker-aware systemd generator, so these dependencies are activated only on installer boots.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Human assessment is needed because critical findings omitted from the published review identify risks of an indefinitely stopped recovery shell and frozen installer controls.
Add HC and COSI autorun, ISO media discovery, recovery, shell and result actions, and a safe local demo. Wire the optional installer RPM and preserve caller-managed reboot policy.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Do not supply implicit settings after a configuration failure. Keep URL-entry controls accurate and installer method visibility scoped to the crate.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the demo's real shell with an inert command screen. Keep reboot and shutdown mocked, render readable structured error details, and avoid duplicating headless errors.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the supplied ASCII wordmark and Trident Linux Installer display name. Keep controls visible at 80x24 and fall back to a compact header for smaller terminals.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep all diagnostic records while selecting display verbosity live. Add coloured RPC logs and blank lines around the cyan wordmark without hiding console actions.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Build matching installer/base RPMs in Azure Linux, reuse a pre-existing non-ACL COSI, and package an autorun ISO. Provide a manual QEMU launcher using fresh storage and disk-first UEFI boot order.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Run headlessly with a loopback-only VNC listener and document the SSH tunnel. Keep GTK support and disposable storage unchanged.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Prevent getty and logind from reclaiming tty1, explicitly foreground the installer, and replace the broad blkid media probe with lsblk. Show each preparation stage on screen and serial. Start VNC guests paused until a viewer connects.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mirror output is best-effort and warns before dropping an unwritable terminal instead of killing the interactive installer. Reproduce a tty write failure in a unit test and document the chosen test COSI's missing EFI loader.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document autorun source selection, colored screen flows, recovery actions and safety controls; link the new page from installer configuration and crate README.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
# 🔍 Description
Decode `file://` URLs with `Url::to_file_path()` in Trident's
`FileReader`, and reject non-local file URL hosts. Add a regression for
local filenames containing spaces and `#`. This PR changes only
`crates/trident/src/io_utils/file_reader.rs`.
# 🤔 Rationale
`Url::path()` retains `%20` and `%23`. Treating it as a literal
filesystem path makes valid local images appear missing. The fix belongs
at Trident's file-reader boundary, independently of the installer in
#819.
# 📝 Validation
**Passed (agent, `58e2d026c`):**
`CARGO_TARGET_DIR=/home/frhuelsz/repos/trident-installer/target cargo
test --locked --offline -p trident --lib io_utils::file_reader::tests
--quiet` (3 tests); `cargo fmt --all`; `cargo fmt --all -- --check`;
`git diff --cached --check`; `git diff --name-status origin/main...HEAD`
(only the file reader changed).
**Pending (CI):** Checks for `58e2d026c` have not yet completed or been
observed. **Not run:** ISO/VM boot; this change is covered by the
focused file-URL regression.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Name the ISO kernel boot argument directly, simplify mode wording, and introduce prerequisites and source concepts before diagrams and controls.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Clarify that installer://image is the only supported reserved image URL and selects the first COSI, not a file named in the URL.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the immediately invoked closure with leave_screen while preserving palette cleanup and error ordering.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Description
Adds
trident-installer, an optional RPM for installer ISOs. It runs Trident with a terminal UI for installation progress, logs, and recovery.trident.installer=1.Includes TOML configuration and an installer reference covering setup, source selection, and screen flows.
Remove the installer media after installation: leaving it first in boot order can reimage the machine on the next boot.
🤔 Rationale
Give installer ISOs a small Rust front end to Trident instead of maintaining separate shell installers.