Repository navigation
[0.84] Route validation npm requests through package proxy - #16480
Merged
anuagragith merged 3 commits intoOct 13, 2026
Merged
anuagragith merged 3 commits into
anuagragith merged 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f63ea4f-a16b-4fa3-b141-785aec89b5e4
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The network-isolation README still documents both registries as using react-native-public.
1 open finding
What changed in this PR
Routes validation-time npm/npx requests through PackageFeedProxy while keeping Yarn on the authenticated feed.
Changes:
- Updates
NPM_CONFIG_REGISTRYto the anonymous proxy. - Separates npm and Yarn routing documentation.
| File | Description |
|---|---|
.ado/variables/shared.yml |
Configures split npm and Yarn registry routing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f63ea4f-a16b-4fa3-b141-785aec89b5e4
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f63ea4f-a16b-4fa3-b141-785aec89b5e4
Vladimir Morozov (vmoroz)
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Motivation
A fresh validation run for #16465 includes the changes from #16467 and confirms that the original Setup failure is resolved.
However, the Fabric X64Hermes and X86Hermes jobs now fail while running: