Skip to content

[0.84] Route validation npm requests through package proxy - #16480

Merged
anuagragith merged 3 commits into
microsoft:0.84-stablefrom
anuagragith:fix/0.84-validation-npm-registry
Oct 13, 2026
Merged

anuagragith merged 3 commits into
microsoft:0.84-stablefrom
anuagragith:fix/0.84-validation-npm-registry

Conversation

@anuagragith

@anuagragith anuagragith commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Routes npm/npx and Yarn package requests used by PR and Continuous validation through the anonymous PackageFeedProxy.
  • Keeps Azure Artifacts authentication scoped to direct npm requests and the Verdaccio uplink.
  • Prevents Yarn from sending the Azure feed token to PackageFeedProxy.

Motivation

A fresh validation run for #16465 includes the changes from #16467 and confirms that the original Setup failure is resolved.
However, the Fabric X64Hermes and X86Hermes jobs now fail while running:

npx --yes @react-native-community/cli codegen-windows --logging

npm returns an  E401  authentication error because later  npx  requests still use the authenticated Azure DevOps npm registry.

Using PackageFeedProxy for  NPM_CONFIG_REGISTRY  allows these PR and CI npm requests to resolve without depending on Azure DevOps feed credentials.

Release safety -
This change does not alter package publishing destinations:
• PR and Continuous pipelines consume  .ado/variables/shared.yml  through  build-template.yml .
•  release-pipeline.yml  does not import  shared.yml .
• npmjs publication uses the ESRP release task.
• Azure DevOps feed publication passes its destination explicitly using  npm publish --registry .
• The Release pipeline retains its own registry configuration for package-existence checks.

Validation:
• Resolved  @react-native-community/cli  through PackageFeedProxy using  npx ; returned version  20.2.0 .
• Prettier check passed for  .ado/variables/shared.yml .
•  git diff --check  passed.
• Confirmed the variable propagates to both PR and Continuous pipelines.
• Confirmed the Release pipeline does not consume the changed variable and publishing remains explicitly registry-scoped.

Related: #16465, #16467
 ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/react-native-windows/pull/16480)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0f63ea4f-a16b-4fa3-b141-785aec89b5e4
Copilot AI balanced review requested due to automatic review settings October 12, 2026 19:20
@anuagragith
anuagragith requested review from a team as code owners October 12, 2026 19:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The network-isolation README still documents both registries as using react-native-public.

1 open finding
What changed in this PR

Routes validation-time npm/npx requests through PackageFeedProxy while keeping Yarn on the authenticated feed.

Changes:

  • Updates NPM_CONFIG_REGISTRY to the anonymous proxy.
  • Separates npm and Yarn routing documentation.
File Description
.ado/​variables/​shared.yml Configures split npm and Yarn registry routing.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .ado/variables/shared.yml Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0f63ea4f-a16b-4fa3-b141-785aec89b5e4
Copilot AI balanced review requested due to automatic review settings October 12, 2026 20:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused configuration and documentation changes are consistent with validation and release pipeline behavior.

1 open finding

🧠 Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0f63ea4f-a16b-4fa3-b141-785aec89b5e4
Copilot AI balanced review requested due to automatic review settings October 12, 2026 22:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Yarn routing and authentication contradict the PR’s explicit requirement to keep Yarn on the existing feed.

1 open finding
1 resolved since last review

🧠 Review effort: Balanced

Comment thread .ado/variables/shared.yml
@anuagragith
anuagragith merged commit 0e7999b into microsoft:0.84-stable Oct 13, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants