Repository navigation
fix(android): remove stale generated resources - #2996
Open
Tommy Nguyen (tido64) wants to merge 1 commit into
Open
Tommy Nguyen (tido64) wants to merge 1 commit into
Tommy Nguyen (tido64) wants to merge 1 commit into
Conversation
`copyResources` and friends used `Copy` tasks, which never delete files that were removed from the sources. Replacing a drawable with one of the same name but a different extension left both in the generated folder, and `mergeDebugResources` failed with "duplicate resources". Use `Sync` instead, with a single task owning each generated directory (fonts are now synced into `assets/fonts` by `copyAssets`, and media into `res/raw` by `copyResources`).
Tommy Nguyen (tido64)
force-pushed
the
tido/android/fix-sync-res
branch
from
October 29, 2026 14:43
9357f86 to
11b3ced
Compare
Tommy Nguyen (tido64)
marked this pull request as ready for review
October 29, 2026 14:54
Tommy Nguyen (tido64)
requested a review
from Jason Morse (JasonVMo)
as a code owner
October 29, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
copyResourcesand friends usedCopytasks, which never delete files that were removed from the sources. Replacing a drawable with one of the same name but a different extension left both in the generated folder, andmergeDebugResourcesfailed with "duplicate resources".Use
Syncinstead, with a single task owning each generated directory (fonts are now synced intoassets/fontsbycopyAssets, and media intores/rawbycopyResources).Resolves #2993.
Platforms affected
Test plan
n/a