Repository navigation
Fix base_url fallback fixture deprecation with pytest 9.2 - #343
Closed
Michel (md-info) wants to merge 1 commit into
Closed
Michel (md-info) wants to merge 1 commit into
Michel (md-info) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pytest-base-url is absent, requesting the fallback
base_urlfixture on pytest 9.2 emitsPytestRemovedIn10Warning. Projects treating this warning as an error cannot set up the page fixture.Make the fallback fixture a static method in both the sync and async plugins. Extend the existing base URL tests to treat this specific warning as an error, preserving coverage for command-line, ini, environment, and unset values without failing on unrelated plugin warnings.
Fixes #341.
Validation:
git diff --checkpassed for the changed files.