Repository navigation
fix(docker): build the client on the host and make utils/docker the build context - #2034
Merged
Yury Semikhatsky (yury-s) merged 9 commits intoNov 4, 2026
Merged
Conversation
Yury Semikhatsky (yury-s)
requested review from
Dmitry Gozman (dgozman) and
Pavel Feldman (pavelfeldman)
November 3, 2026 03:00
Yury Semikhatsky (yury-s)
force-pushed
the
fix-docker-source-layer
branch
from
November 3, 2026 20:34
3f9de48 to
2351d84
Compare
… stage - Send only the build inputs to the Docker build context: .dockerignore is an allowlist, which keeps VCS metadata and CI-written files out of it. - Bind-mount the build context into a separate builder stage instead of COPYing it. The final stage gets only the playwright-java artifacts of the local Maven repository and runs the CLI from a bind mount of the builder's classes and runtime dependencies.
Yury Semikhatsky (yury-s)
force-pushed
the
fix-docker-source-layer
branch
from
November 4, 2026 00:31
2351d84 to
0ea6f52
Compare
…uild context Like the other language ports, build.sh builds the client on the host and stages what the image needs under utils/docker/dist: the playwright-java artifacts for the local Maven repository and the CLI jars. The Dockerfiles COPY the former and run the CLI from a bind mount of the latter, so the image no longer builds from source and the repository is not part of the build context. The root .dockerignore is no longer needed.
…gnore the rest of the context Reword the pipeline comments for the client build on the host, and add a .dockerignore for the utils/docker build context that admits only dist/ and maven/.
Yury Semikhatsky (yury-s)
changed the title
- Drop MAVEN_SETTINGS_SECRET: the host build reads ~/.m2/settings.xml, which is where the pipeline puts the authenticated settings anyway. - Read the project version and the local repository in one exec:exec call, the plugin pom.xml pins, like publish_docker.sh does. - Fold mkdir /ms-playwright into the CLI step, run install --with-deps instead of install-deps and install, and drop the redundant DEBIAN_FRONTEND prefix. - Ignore utils/docker/dist in utils/docker/.gitignore next to oras.
Like the other language ports, the image ships the runtime, the browsers and their dependencies; the client comes from the user's own build. The staged client jars are only mounted to run the CLI, and /root/.m2 is gone from the image. The Docker workflow copies the SNAPSHOT artifacts that build.sh installed on the runner into the container for the tests.
The comments described the settings as mirroring Maven Central to the DevDiv_PublicPackages feed. They route every download through the feed instead of Maven Central, as the settings file itself says.
Dmitry Gozman (dgozman)
approved these changes
Nov 4, 2026
The Maven settings are explained where they are copied, and build.sh describes how it uses them.
Yury Semikhatsky (yury-s)
merged commit Nov 4, 2026
be0cf6d
into
microsoft:main
18 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils/docker/build.shbuilds the client on the host and stages the client jar and its runtime dependencies underutils/docker/dist/.utils/dockeris the Docker build context, so the repository never reaches the image.dist/only to run the CLI that installs the driver, the browsers and their dependencies; the client itself is not baked into the image, and the image needs no Maven settings secret.utils/docker/.dockerignoreadmits onlydist/andmaven/, and keeps the explicit VCS and credential exclusions.build.shinstalled on the runner into the container for the tests.