Skip to content

fix(serialization-text): parse "none" as the None_ enum member #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vincent Biret (baywet) merged 2 commits into from
Oct 15, 2026
Merged

fix(serialization-text): parse "none" as the None_ enum member #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
224a795
fix(serialization-text): parse "none" as the None_ enum member
anishmehta24 Oct 15, 2026
af53ea5
Merge branch 'main' into fix/text-none-enum
baywet Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/serialization/text/kiota_serialization_text/text_parse_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ def get_enum_value(self, enum_class: K) -> Optional[K]:
raw_key = self.get_str_value()
camel_case_key = None
if raw_key:
camel_case_key = raw_key[0].upper() + raw_key[1:]
if raw_key.lower() == "none":
# None is a reserved keyword in python
camel_case_key = "None_"
else:
camel_case_key = raw_key[0].upper() + raw_key[1:]
if camel_case_key:
try:
return enum_class[camel_case_key] # type: ignore
Expand Down
11 changes: 11 additions & 0 deletions packages/serialization/text/tests/unit/test_text_parse_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import json
from datetime import date, datetime, time, timedelta
from enum import Enum
from uuid import UUID

import pytest
Expand Down Expand Up @@ -114,6 +115,16 @@ def test_get_enum_value():
assert result == OfficeLocation.Dunhill


def test_get_enum_value_none_member():
class RiskLevel(Enum):
Low = "low"
None_ = "none"

parse_node = TextParseNode("none")
result = parse_node.get_enum_value(RiskLevel)
assert result == RiskLevel.None_


def test_get_object_value(sample_structured_data):
with pytest.raises(Exception) as e_info:
parse_node = TextParseNode(sample_structured_data)
Expand Down
Loading