fix single-instance orchestration purge requests - #165
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Tomer Rosenthal (torosent)
marked this pull request as ready for review
September 29, 2026 16:11
Copilot started reviewing on behalf of
Tomer Rosenthal (torosent)
September 29, 2026 16:12
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused protocol fix is correct and covered by both request-level and end-to-end regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes single-instance orchestration purges by setting the required protocol discriminator.
Changes:
- Sets
IsOrchestrationon single-instance purge requests. - Adds request-level and DTS emulator regression tests.
- Verifies existing recursive and error behavior.
| File | Description |
|---|---|
client/client_grpc.go |
Sets the orchestration purge discriminator. |
client/client_grpc_management_test.go |
Tests wire fields and error handling. |
tests/durabletaskscheduler/dts_emulator_test.go |
Verifies targeted deletion against DTS. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
halspang
approved these changes
Sep 29, 2026
Tomer Rosenthal (torosent)
deleted the
torosent-single-instance-purge
branch
September 29, 2026 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
PurgeOrchestrationStatesent a single-instance purge request without settingIsOrchestration=true. The protocol uses this flag to distinguish orchestrations from entities, so the request carried the wrong default discriminator.The pinned DTS emulator accepted the old request and deleted the orchestration in our test. The reproduced defect is the missing wire field, not proof that every deployed service rejects the request. The old request was not tested against live DTS.
The fix
What this means for purging
Recursion options and error behavior stay the same. Default purges remain nonrecursive, and
WithRecursivePurgestill controls child deletion. Purge completion handling is unchanged.