Repository navigation
feat: add a containerd config to enable EROFS snapshotter and referrer flag when IPE is enabled - #98
Merged
Dallas Delaney (dallasd1) merged 8 commits intoOct 19, 2026
Conversation
Dallas Delaney (dallasd1)
deployed
to
development
October 9, 2026 17:51 — with 
GitHub Actions
Active
GitHub Actions
Active
There was a problem hiding this comment.
🟡 Changes recommended
The documented enforcing-mode behavior contradicts the loader implementation and its tests.
1 open finding
What changed in this PR
Adds IPE-triggered EROFS configuration for containerd while preserving the selected base configuration.
Changes:
- Adds EROFS tooling and containerd profile assets.
- Installs the profile after IPE activation.
- Adds runtime/offline validation and documentation.
| File | Description |
|---|---|
build_library/rpm/sysext_mangle_containerd-flatcar.sh |
Installs EROFS profile assets. |
build_library/rpm/dracut_install.sh |
Adds the profile to the IPE dracut module. |
build_library/rpm/additional_files/dracut-acl-ipe-load/module-setup.sh |
Installs the profile into initramfs. |
build_library/rpm/additional_files/dracut-acl-ipe-load/acl-ipe-load.sh |
Activates the containerd drop-in with IPE. |
build_library/rpm/additional_files/containerd2/containerd-acl-select-profile |
Merges and validates containerd configurations. |
build_library/rpm/additional_files/containerd2/containerd-acl-profile.conf |
Overrides containerd startup for EROFS. |
build_library/rpm/additional_files/containerd2/containerd-acl-erofs.toml |
Configures EROFS snapshotting and referrers. |
acl/tests/ipe/run-ipe-audit-test.sh |
Validates the active containerd profile. |
acl/tests/ipe/offline/test-ipe-loader-runtime.sh |
Tests profile installation by IPE mode. |
acl/sysexts.yaml |
Adds erofs-utils to the containerd sysext. |
acl/docs/BUILD_RPM_IMAGE_README.md |
Documents IPE/containerd integration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
9 of 16 tasks
Dallas Delaney (dallasd1)
marked this pull request as ready for review
October 10, 2026 01:02
mayankfz
reviewed
Oct 13, 2026
- update documentation distinguishing audit mode behavior vs. enforcing - dont fail containerd if the merged config has conflicts in audit mode. Use the base config instead and deal with audit denials - add tests to check more config combinations - add extra config validation checks for built-in containerd transfer service conflicts
Dallas Delaney (dallasd1)
deployed
to
development
October 14, 2026 03:41 — with
GitHub Actions
Active
GitHub Actions
Active
mayankfz
reviewed
Oct 14, 2026
- fix handling of config validation by checking what the containerd binary supports before sending an error - refactor erofs profile selection validation logic and move each check to its own function - add unpack_config transfer config checks and tests - add live VM test for config checking
Dallas Delaney (dallasd1)
deployed
to
development
October 16, 2026 00:15 — with
GitHub Actions
Active
GitHub Actions
Active
Dallas Delaney (dallasd1)
deployed
to
development
October 16, 2026 15:19 — with
GitHub Actions
Active
GitHub Actions
Active
Dallas Delaney (dallasd1)
deployed
to
development
October 16, 2026 15:21 — with
GitHub Actions
Active
GitHub Actions
Active
- add check for erofs differ field in erofs snapshotter config - make naming more consistent for containerd-acl-profile.conf
Dallas Delaney (dallasd1)
deployed
to
development
October 16, 2026 16:44 — with
GitHub Actions
Active
GitHub Actions
Active
There was a problem hiding this comment.
🟡 Changes recommended
Unpack configuration validation rejects supported automatic differ selection and misses explicitly empty unpack configurations.
5 open findings
1 resolved since last review
🧠 Review effort: Balanced
Dallas Delaney (dallasd1)
deployed
to
development
October 18, 2026 17:12 — with
GitHub Actions
Active
GitHub Actions
Active
aadhar-agarwal
approved these changes
Oct 18, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a containerd config to enable EROFS snapshotter and referrer flag when IPE is enabled. This config change will only be triggered if IPE is in audit mode.
When IPE is set, IPE's loader will run the acl-select-profile script to merge the base containerd config that AgentBaker or ACL sets with the EROFS config. The merged configuration check is only meant to be used against the base ACL and base AgentBaker configurations, not a general config validator. None of the settings in the base config get overwritten.
This is a follow up PR for after the containerd2 patch enabling dmverity referrers is merged: #99
Change Log
Type of Change
Does this affect the image build?
Associated Issues
Test Methodology
Merge Checklist
All applicable boxes should be checked before merging