Fix the winforms build output path in the manifest - #119
Merged
AmirMS (AmelBawa-msft) merged 1 commit intoSep 29, 2026
Merged
Conversation
The build wrote hello.exe to tests/winforms/bin while the run step executed src\tests\winforms\bin\hello.exe, so the manual flow could not pass as written. Both now use src/tests/winforms/bin, matching the dotnet and winui flows.
AmirMS (AmelBawa-msft)
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the CI harness locally to check my own changes, which is how I noticed that the winforms flow cannot pass as written.
src/manifest.ymlbuilds the WinForms hello world with-o tests/winforms/binbut runssrc\tests\winforms\bin\hello.exe, so the run step never finds the binary. The flow ismanual_test: true, which is presumably why CI has not caught it.Both paths now use
src/tests/winforms/bin, matching the dotnet and winui flows.Checked on Windows 11 Pro 25H2 (build 26200.9550) with dotnet 10.0.401, running the manifest's build, run and expected values through
./src/tests/_harness/run-flow.ps1 -Id winformsfrom the repository root on06200f0. With the current manifest,dotnet buildsucceeds and writestests/winforms/bin/hello.exe, then the run step fails withThe system cannot find the path specified.(run failed with exit code 1). With this change the same run printsWinForms: hello-winformsandFLOW_OK: winforms.Thanks for having a look.