Repository navigation
chore(deps): update to October 2026 windows-drivers-rs release - #67
Merged
Merged
Conversation
Replace the windows-drivers-rs main-branch patches with the latest crates.io releases and update the cargo-make loader to wdk-build 0.6.0. Refresh Cargo.lock while retaining bindgen's compatible Syn 2 resolution.
There was a problem hiding this comment.
🔵 Needs a closer look
Cargo.lock still contains duplicate windows-sys and shlex versions that can trigger clippy::cargo multiple_crate_versions failures, while CI treats warnings as errors.
No open issues 🎉
What changed in this PR
Updates the Rust driver samples to the October 2026 windows-drivers-rs release and refreshes the dependency lockfile.
Changes:
- Bumps the WDK workspace dependencies to the October 2026 versions.
- Updates the Cargo Make loader to use
wdk-build 0.6.0. - Refreshes direct and transitive dependencies in
Cargo.lock. - The lockfile still contains multiple versions of
syn,windows-sys, andshlex, which can fail Clippy under the repository’s-D warningsconfiguration.
This pull request requires changes.
| File | Description |
|---|---|
Makefile.toml |
Updates the embedded Cargo Make loader to wdk-build 0.6.0. |
Cargo.toml |
Updates workspace dependency versions for the October 2026 release. |
Cargo.lock |
Records the refreshed dependency graph, but retains multiple versions of syn, windows-sys, and shlex, leaving clippy::multiple_crate_versions unresolved. |
Review effort: Lite (auto)
serde_derive 1.0.229 moved to syn 3 while bindgen, wdk-macros and clap_derive are still on syn 2, which trips clippy's multiple_crate_versions lint.
Cargo's build-dir layout v2 nests rust-script's long package name twice, pushing the cargo-make load_script binary past MAX_PATH. Point build-dir at a short path via a rust-script-scoped cargo config so driver builds, which rely on OUT_DIR being under the workspace, are unaffected.
There was a problem hiding this comment.
🔵 Needs a closer look
The dependency upgrade changes kernel-facing wdk/wdk-panic behavior and Windows build paths, while its driver compilation, panic handling, packaging, and full EWDK architecture matrix require validation in the repository’s Windows CI environment.
No open issues 🎉
Review effort: Lite (auto)
Melvin Wang (wmmc88)
marked this pull request as ready for review
October 28, 2026 05:40
Melvin Wang (wmmc88)
enabled auto-merge (squash)
October 28, 2026 05:42
Alan632
approved these changes
Oct 29, 2026
Krishna Kumar Thokala (krishnakumar4a4)
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the samples to the October 2026 windows-drivers-rs release from crates.io: wdk 0.5.0, wdk-sys 0.5.2, wdk-build 0.6.0, wdk-alloc 0.4.2, and wdk-panic 0.5.0. The cargo-make loader in
Makefile.tomlnow points at wdk-build 0.6.0 too.Release PR: microsoft/windows-drivers-rs#751