Repository navigation
Add missing synchronization around load WinHttp proxy methods - #41909
Open
Blue (OneBlue) wants to merge 2 commits into
Open
Blue (OneBlue) wants to merge 2 commits into
Blue (OneBlue) wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Failed function loads are incorrectly converted to success, leaving required optionals empty.
1 open finding
What changed in this PR
Moves WinHTTP API loading under one-time synchronization to prevent concurrent writes.
Changes:
- Synchronizes module and function loading with
std::call_once. - Caches the load result for subsequent callers.
| File | Description |
|---|---|
src/windows/service/exe/LxssHttpProxy.cpp |
Makes WinHTTP proxy API initialization thread-safe. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
David Bennett (dkbennett)
approved these changes
Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of the Pull Request
This change moves the entire loading of the winhttp methods under the
std::call_once, otherwise two threads could be trying to load the methods in parallel and write the global std::optionals at the same timePR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed