Repository navigation
Release resources that could call callbacks before returning from HcsVirtualMachine's constructor on failure - #41908
Merged
Merged
Conversation
…VirtualMachine's constructor on failure
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The cleanup preserves required teardown ordering and releases the lock before draining callbacks.
0 open findings
What changed in this PR
Prevents use-after-free during HcsVirtualMachine constructor failure by draining callback-producing resources before member destruction.
Changes:
- Uses an unlockable constructor lock.
- Adds failure-only cleanup for device-manager and HCS callbacks.
| File | Description |
|---|---|
src/windows/service/exe/HcsVirtualMachine.cpp |
Safely drains callbacks during failed construction. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ben Hillis (benhillis)
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves a potential crash if
HcsVirtualMachinethrows an exception. If that happens, its destructor won't run, and its field will be destroyed in reverse-order. That can cause a use-after-free in callbacks from the guest device manager or compute system are being called.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed