Repository navigation
Fix missing synchronization on m_httpProxyStateTracker access - #41907
Open
Blue (OneBlue) wants to merge 5 commits into
Open
Blue (OneBlue) wants to merge 5 commits into
Blue (OneBlue) wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The tracker remains a plain std::shared_ptr, so the new atomic member calls do not compile.
1 open finding
What changed in this PR
Adds synchronized access to the HTTP proxy state tracker.
Changes:
- Replaces direct accesses with atomic load/store operations.
- Uses compare-and-exchange during tracker initialization.
| File | Description |
|---|---|
src/windows/service/exe/LxssUserSession.cpp |
Synchronizes proxy tracker access and initialization. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
David Bennett (dkbennett)
approved these changes
Oct 13, 2026
David Bennett (dkbennett)
left a comment
David Bennett (dkbennett)
left a comment
Member
There was a problem hiding this comment.
As with similar bugs, regression test would be nice but these fixes look like goodness to me regardless and synchronization tests can be tricky to get right and could be flaky so I'm OK skipping them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change adds missing synchronization around reading and writing to
m_httpProxyStateTracker.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed