Repository navigation
Add wslc cp alias for wslc container cp - #41902
Open
ggarzia-MSFT wants to merge 6 commits into
Open
ggarzia-MSFT wants to merge 6 commits into
ggarzia-MSFT wants to merge 6 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new alias’s help text incorrectly advertises only the nested command spelling.
1 open finding
What changed in this PR
Adds wslc cp as a top-level alias for wslc container cp.
Changes:
- Registers the existing container copy command at the root.
- Adds parsing tests for the new alias.
| File | Description |
|---|---|
src/windows/wslc/commands/RootCommand.cpp |
Registers the top-level cp command. |
test/windows/wslc/CommandLineTestCases.h |
Tests basic alias parsing and -L. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…garzia/wslc-cp-alias
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…garzia/wslc-cp-alias
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| std::wstring ContainerCpCommand::LongDescription() const | ||
| { | ||
| return Localization::WSLCCLI_ContainerCpLongDesc(); | ||
| return Localization::WSLCCLI_ContainerCpDesc(); |
ranm-msft
approved these changes
Oct 13, 2026
ranm-msft
left a comment
There was a problem hiding this comment.
Approving.
Checked that the help-output change is byte-identical for the non-full-help path, so the only rendering difference is in full help. The localization placeholders are correctly moved into non-localized C++ literals rather than being left inside the localized strings, which is the right split. Tests were added for both cp --help and container cp --help.
David Bennett (dkbennett)
approved these changes
Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds
wslc cpas a top-level alias forwslc container cp. matchingdocker cpAlso allows for adding usage examples to a command's help output