Repository navigation
memory: add opt-in Wiki relationship and Inbox review workflow - #3292
Open
Hillary Mutisya (hillary-mutisya) wants to merge 3 commits into
Open
Hillary Mutisya (hillary-mutisya) wants to merge 3 commits into
Hillary Mutisya (hillary-mutisya) wants to merge 3 commits into
Conversation
Keep related subjects independent, retain qualified new partial drafts, and reserve one evidence-bound Sol arbitration with durable Inbox review. Revalidate source access, citations, revisions and preservation before applying drafts; keep native model replacement separate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep draft-save complexity within the existing budget without changing quality semantics, and expose the focused Wiki browser fixture separately from unrelated browser qualification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Wiki candidates can be related without being duplicates, and useful draft material can be partially grounded without being safe to combine with or replace an existing article. Previously unresolved cases need a durable, evidence-bound review path rather than disappearing into construction failures or granting implicit merge authority.
This PR separates that shared workflow from changing the underlying decision model. It retains the existing configured Luna-backed decision path.
Behavior and configuration
FileMemoryServiceOptions.wikiReview: trueorTYPEAGENT_MEMORY_WIKI_REVIEW=truethrough configured memory hosts.GPT_6_1_SOL, one durable logical reservation per frozen evidence/revision set, bounded recorded transport retries, no alternate-model fallback or recursive semantic repair. Interrupted or unsuccessful calls remain reviewable.Reviewer guide
Validation
Local validation on Windows with Node 26.13.0. Full build, pinned formatting and all four committed whole-branch gates passed again at current head 9c8e47d, against fetched main 4f2d364.
The broad tests below passed on the initial implementation 8e1367f. Follow-up 34cc3fd extracts the unchanged draft-quality copy expression into a helper to stay within the complexity budget and gives the browser fixture its own test command. After that refactor, the five affected save/partial/restart suites passed 101/101. The policy bot's 9c8e47d only alphabetizes that package script key; it changes no executable source or test content. No prior result is being presented as a fresh full rerun.
ts:pnpm run buildpnpm run jest-esm --runInBand --runTestsByPathselectingwikiAmbiguity,viewSupport,wikiDecision,wikiAdmission,wikiPlanningRecovery,viewHostOptions,wikiConsolidation,wikiContribution,wikiGrouping,viewEditorial,informationalWiki,viewSeparationService,filesystemPublication,wikiConsolidationRecovery,wikiConsolidationTemporalcompiled specsviewStore,viewStoreReview,viewDrafts,wikiAmbiguity,viewSupportspecs,--runInBand --runTestsByPathpnpm run test:localwikiAmbiguityProtocol,consolidationProtocol,capabilitiesProtocol,viewInventoryProtocol,editorialProtocol,viewBuildProtocolspecspnpm run test:views:clientchromeRpcRouting,browserViewNavigation,indexJest suitesnode --test test/viewGateway.test.mjs test/viewDraftGateway.test.mjs test/viewLifecycle.test.mjs test/memoryHub.test.mjspnpm run test:views:wiki-review-browserpnpm run prettier:changedpnpm run code-lint -- --ratchet --base origin/mainpnpm run code-complexity -- --ratchet --base origin/main --cyclomatic 25 --cognitive 30 --new-file-cyclomatic 25 --new-file-cognitive 30pnpm run code-circular -- --ratchet --base origin/main --exceptions-file tools/scripts/code/circular-baseline-exception.jsonpnpm run code-debt -- --gate --base origin/mainUI verification: the real-browser fixture imports the production Inbox card renderer with synthetic evidence and checks complete evidence visibility, all three guarded actions, stale errors and refresh errors. The renderer suite separately mounts the Hub activity feed and verifies disabled read-only review behavior. Prerequisite: a compatible local Chromium (
TYPEAGENT_BROWSER_EXECUTABLE) or Puppeteer's pinned Chrome (pnpm exec puppeteer browsers install chrome). No recording, real-user payload, live model call or latency measurement was used.Risks, limitations and rollout
This is an opt-in initial release. Sol availability and model judgments remain operational/quality risks, so failed or unverifiable proposals stay visible and original pages are retained. The edit surface is structured JSON, not a visual merge editor.
Deterministic and browser verification do not establish live model accuracy, Sol cost or end-to-end readiness latency. This PR makes no performance claim, does not enable native Decision1 and does not qualify default enablement.
Current-head CI and review status
The policy bot's follow-up was fetched and fast-forwarded locally, then the full build, formatting and all four branch gates were rerun successfully.
GitHub Actions has not executed jobs for the current head: eight bot-triggered workflow runs report
action_required. The build-ts run explicitly says it is awaiting approval from a maintainer. A maintainer must approve the workflows before current-head CI can be assessed; previous-head checks are not a substitute. Azure smoke tests are separately in progress.The feedback inventory found no reviews, inline comments or unresolved threads. CI observation stopped at the verified manual-approval gate; no watcher remains active. This PR is not being reported CI-green or ready to merge.