Repository navigation
memory: use restricted Luna for topic reconciliation - #3288
Merged
Hillary Mutisya (hillary-mutisya) merged 3 commits intoNov 15, 2026
Merged
Hillary Mutisya (hillary-mutisya) merged 3 commits into
Hillary Mutisya (hillary-mutisya) merged 3 commits into
Conversation
Keep original generative curation as the default. Add opt-in decomposed and native-shaped GPT partition judgments with separate source-grounded authoring, strict answer validation and explicit resolution receipts. Preserve frozen preparation and reject admission failures without extra fallback attempts. The bounded live pilot preserves ownership accounting but does not qualify default promotion: output probability arithmetic remains unreliable and total latency regresses. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep preparation and descriptive authoring generative, validate bounded membership answers, and retain explicit original-generative resolution. Add a validated rollback setting and account for decision and authoring requests during token packing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
CI resolved on unchanged head |
Hillary Mutisya (hillary-mutisya)
enabled auto-merge
November 15, 2026 23:08
Hillary Mutisya (hillary-mutisya)
disabled auto-merge
November 15, 2026 23:08
Hillary Mutisya (hillary-mutisya)
merged commit Nov 15, 2026
ef2da48
into
main
188 of 197 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation and evidence
Separate bounded semantic decisions from descriptive authoring, making the decision contract explicit without migrating to the native Decision service.
A fresh matched diagnostic ran 12 source-disjoint tasks with four candidates each, three interfaces and three repeats: 108 model methods. All interfaces received identical caller-visible instructions, evidence and choices; the two Luna wire requests differed only in output schema.
Restricted Luna passed 35/36 complete contracts. Excluding its one non-unit reply changes the full/restricted disagreement rate to 28/140 (20.0%). This supports the requested scoped rollout, not a correctness-equivalence claim: these are correlated comparisons of 48 unique candidates, the common diagnostic prompt differs from production framing, and agreement is not a quality label. Native D1's hidden templates/decoding were not observable, and only 28/36 native replies formed complete consistent partitions.
There is no end-to-end speed claim. An earlier small integrated pilot measured median full-construction times of 35.6 seconds for original generative and 51.8 seconds for the restricted path, including fallback (three runs per arm). The extra decision/authoring split and fallback work remain explicit.
Behavior and configuration
generativeDecisionStage:output-contract.TYPEAGENT_MEMORY_TOPIC_GENERATIVE_DECISION_STAGE=original, ortopicCuration: { generativeDecisionStage: "original" }. Thedecomposedchoice-only control remains available for diagnostics.answerswith typed choices, all offered probabilities and confidence. No probability repair, invented confidence, argmax threshold or source-specific rules are introduced.:generative-partition-v1:output-contract. Original rollback preserves the old recipe. Changed policy/packet identities cannot resume original-policy work by relabeling it.Reviewer guide
Validation
Tested commit
422666d74on Windows, Node 26.13.0, standalone pnpm 11.9.0. All commands below run fromts, except the indicated package-local Jest commands.pnpm run build: passed.(topic.*|viewHostOptions)[.]spec[.]js$, with--runInBand: 318 tests in 17 suites.decisionModels[.]spec[.]js$, with--runInBand: 96 tests.pnpm run ci:node --test tools/memory-maintenance-qualification/topic-curation-options.test.mjs tools/memory-maintenance-qualification/topic-curation-replay.test.mjs: 28 tests.pnpm run test:memory-quality: all 375 offline root-suite tests passed, including benchmark configuration identity.pnpm run prettier:changed: passed.pnpm run code-lint -- --ratchet --base origin/main: passed, zero violations across nine changed source files.pnpm run code-complexity -- --ratchet --base origin/main --cyclomatic 25 --cognitive 30 --new-file-cyclomatic 25 --new-file-cognitive 30: passed, including both new source files.pnpm run code-circular -- --ratchet --base origin/main --exceptions-file tools/scripts/code/circular-baseline-exception.json: passed, 210 cycles unchanged and 11 unchanged exceptions.pnpm run code-debt -- --gate --base origin/main: passed, no focused/new skipped tests across 17 changed source/test files.These are offline regression checks. No new live inference was run while preparing this PR; the measurements above are the completed diagnostic/pilot evidence, not tests of production readiness or latency on this final tree.
The first CI run caught one stale LongMemEval benchmark-default assertion on Linux Node 24 and 26. Commit
422666d74updates that expected identity and checks that explicit original-generative rollback is recorded. The complete affected root suite, workspace build, topic/client tests, formatting and committed-source gates passed locally after the correction. Both Linux root suites now pass in CI on the follow-up head.The later six
build_tsfailures all propagated from macOS Node 24 shard 4 being cancelled during dependency/runtime setup, before tests executed. After the workflow finished, a targeted retry succeeded: run 43767555530, attempt 2, on unchanged head422666d74. The retried setup and test steps, sharded qualification,TypeScript CIand all six matrix checks passed. Current verified snapshot: 106 passing checks, three non-required skips, no failures or pending checks, and all required checks including smoke tests passing. No source or CI-policy changes were needed for this failure. Human approval remains required; monitoring has ended.Risks and rollout
The decision/authoring split can add latency, and malformed numeric output can add fallback work. Numeric validity does not establish semantic quality. Monitor decision, authoring, fallback and installed-output outcomes separately. Retain the original rollback setting; do not treat native D1 as the replacement or silently weaken validation to improve completion rates.