Repository navigation
memory: make frozen topic preparation the only generative path - #3283
Merged
Hillary Mutisya (hillary-mutisya) merged 2 commits intoNov 13, 2026
Merged
Conversation
Prepare raw packets in bounded frozen windows and reconcile them serially. Remove legacy serial/speculative scheduling controls, default prior deltas and compact IDs on, and invalidate older curation receipts without changing optional packet budgets or native Decision execution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Expose lightweight experiment configuration and view detail entry points, preserving existing exports. Use them in the view gateway and client schemas so child startup does not import the corpus, indexing and model dependency graph. Add a real ESM import-boundary regression without increasing readiness deadlines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Fixed the reported Windows CI failure in c8b1f8a. The browser view child was eagerly loading the memory/index/model runtime through two import paths: experiment configuration and memory-client paging constants. Both now use lightweight service entry points. The existing readiness deadline is unchanged, and an ESM import-boundary regression covers both paths. Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
#3282 added frozen preparation, but ordinary production configuration still selected the old serial path. This promotes the frozen implementation instead of retaining competing schedules that can repeatedly invalidate speculative proposals.
Behavior and migration
true. Input-token targets and reserved prior fractions remain optional; this does not make the historical 24,000-token / 0.25-fraction treatment the default.TYPEAGENT_MEMORY_TOPIC_CONCURRENCYandTYPEAGENT_MEMORY_TOPIC_FROZEN_PREPARATION, including their former candidate values. Their programmatic counterparts,concurrencyandfrozenPreparation, also fail explicitly.--concurrency,--frozen-preparationand--no-frozen-preparation.topic-parallelexperiment.indexing-parallelnow selects only synopsis and embedding treatments; indexing ablation no longer offers the obsoleteT1arm.curated-lazy-v10:<hash>recipe prevents older-policy progress/receipts from qualifying as current work. Recorded replay requires a matching recording identity; historical progress is rejected rather than relabeled.Reviewer guide
Validation
Initial promotion validated at
fc54c3ceeon Windows againstorigin/mainat3317b2a4a.pnpm run buildpnpm run test:memory-qualitypnpm run ci:node --test tools/memory-maintenance-qualification/topic-work-benchmark.test.mjsgit diff --checkorigin/mainService test selection, from
ts, in PowerShell:Additional legacy offline-harness suite: 9 passed, 1 pre-existing failure. Its worker-bootstrap test fails before the intended missing-profile check because unchanged trace instrumentation expects the absent
runner.verifyContributionRefreshhook. Running the originalorigin/mainharness assertions reproduces the same failure (8 passed, 1 failed); this is not a clean-baseline full-build claim. The newly added compiled-settings provenance assertion passes. This unrelated harness issue is not repaired here.CI repair at
c8b1f8aa3The Windows Node 24 remainder shard failed in browser
viewLifecycle.test.mjs: the real child view server exceeded its existing 10-second readiness deadline. It eagerly loaded the entire memory runtime twice through independent import paths: experiment configuration in the gateway and paging constants in the memory client.The follow-up exposes lightweight
performance-experimentsandview-detailservice entry points and uses them at those boundaries. Existing root exports and configuration behavior are preserved. A real ESM loader-hook regression rejects accidental imports of the full memory, indexing or model runtimes during gateway startup. It failed before the repair and passes afterward.The production readiness deadline and lifecycle-test timeout are unchanged; no workflow, retry budget or test coverage was weakened.
Local validation of the repair on Windows, Node 26.13.0:
pnpm run build: passed across the full workspace.pnpm run test:local: 1,071 passed, including all 130 gateway tests and all 516 view-client tests.pnpm run test:local: 81 passed, including pagination/protocol coverage.The new CI run must verify the originally failing Windows Node 24 shard; local validation is not a claim that the remote run has completed.
Risks and follow-up