Skip to content

memory: make frozen topic preparation the only generative path - #3283

Merged
Hillary Mutisya (hillary-mutisya) merged 2 commits into
mainfrom
dev/hillarym/topic-frozen-default
Nov 13, 2026
Merged

Hillary Mutisya (hillary-mutisya) merged 2 commits into
mainfrom
dev/hillarym/topic-frozen-default

Conversation

@hillary-mutisya

@hillary-mutisya Hillary Mutisya (hillary-mutisya) commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Make frozen two-packet preparation the only generative topic-curation schedule, followed by ordered reconciliation and complete-window commits.
  • Remove the legacy serial/speculative scheduler and its configuration selectors.
  • Align production, replay, watermark and benchmark identities with the new defaults while preserving native Decision execution.

Motivation

#3282 added frozen preparation, but ordinary production configuration still selected the old serial path. This promotes the frozen implementation instead of retaining competing schedules that can repeatedly invalidate speculative proposals.

Behavior and migration

  • Prior deltas and compact wire IDs now default to true. Input-token targets and reserved prior fractions remain optional; this does not make the historical 24,000-token / 0.25-fraction treatment the default.
  • Remove TYPEAGENT_MEMORY_TOPIC_CONCURRENCY and TYPEAGENT_MEMORY_TOPIC_FROZEN_PREPARATION, including their former candidate values. Their programmatic counterparts, concurrency and frozenPreparation, also fail explicitly.
  • Remove replay flags --concurrency, --frozen-preparation and --no-frozen-preparation.
  • Remove the topic-parallel experiment. indexing-parallel now selects only synopsis and embedding treatments; indexing ablation no longer offers the obsolete T1 arm.
  • The new curated-lazy-v10:<hash> recipe prevents older-policy progress/receipts from qualifying as current work. Recorded replay requires a matching recording identity; historical progress is rejected rather than relabeled.
  • Reuse and private watermarks remain opt-in. Failed/cancelled preparation cannot checkpoint a partial window; exact validated prefixes can still be reused.
  • Serial reconciliation and installation are intentional. The shared single-pass evidence primitive remains necessary inside frozen preparation/reconciliation and native uncertainty resolution; it is not an alternate host scheduling mode.
  • Native Decision concurrency and its existing resolution behavior remain unchanged. The explicit raw diagnostic path also remains available.

Reviewer guide

  1. Settings and policy identity, then generative orchestration.
  2. Frozen windows and native uncertainty resolution. Evidence validation continues to reuse the snapshot-local index.
  3. Service wiring, host configuration, and captured-work reuse.
  4. Replay/migration guide, replay identity/capture tests, and service tests for window draining, cancellation, resumptions, append/correction/forget churn and exact output parity.

Validation

Initial promotion validated at fc54c3cee on Windows against origin/main at 3317b2a4a.

Check Result
pnpm run build Passed, 104 tasks
All topic service suites plus host options, maintenance priority and performance experiments 321 passed, 17 suites
pnpm run test:memory-quality 375 passed, no skips
pnpm run ci:node --test tools/memory-maintenance-qualification/topic-work-benchmark.test.mjs 3 passed; exact frozen call counts, prefix reuse and output parity
Repository-pinned Prettier and git diff --check Passed
Committed-HEAD lint, complexity, circular-dependency and test-debt gates against origin/main All four passed; no new violations, cycles or skips

Service test selection, from ts, in PowerShell:

Set-Location packages\memory\service
$tests = @(Get-ChildItem dist\test\topic*.spec.js | ForEach-Object { $_.FullName })
$tests += @('viewHostOptions', 'maintenanceBuildPriority', 'memoryPerformanceExperiments') |
    ForEach-Object { (Resolve-Path "dist\test\$_.spec.js").Path }
pnpm run jest-esm --runTestsByPath @tests

Additional legacy offline-harness suite: 9 passed, 1 pre-existing failure. Its worker-bootstrap test fails before the intended missing-profile check because unchanged trace instrumentation expects the absent runner.verifyContributionRefresh hook. Running the original origin/main harness assertions reproduces the same failure (8 passed, 1 failed); this is not a clean-baseline full-build claim. The newly added compiled-settings provenance assertion passes. This unrelated harness issue is not repaired here.

CI repair at c8b1f8aa3

The Windows Node 24 remainder shard failed in browser viewLifecycle.test.mjs: the real child view server exceeded its existing 10-second readiness deadline. It eagerly loaded the entire memory runtime twice through independent import paths: experiment configuration in the gateway and paging constants in the memory client.

The follow-up exposes lightweight performance-experiments and view-detail service entry points and uses them at those boundaries. Existing root exports and configuration behavior are preserved. A real ESM loader-hook regression rejects accidental imports of the full memory, indexing or model runtimes during gateway startup. It failed before the repair and passes afterward.

The production readiness deadline and lifecycle-test timeout are unchanged; no workflow, retry budget or test coverage was weakened.

Local validation of the repair on Windows, Node 26.13.0:

  • pnpm run build: passed across the full workspace.
  • Browser pnpm run test:local: 1,071 passed, including all 130 gateway tests and all 516 view-client tests.
  • Memory client pnpm run test:local: 81 passed, including pagination/protocol coverage.
  • Memory service host/configuration suites: 33 passed.
  • Repository-pinned formatting, whitespace check and all four committed-HEAD ratchets: passed.

The new CI run must verify the originally failing Windows Node 24 shard; local validation is not a claim that the remote run has completed.

Risks and follow-up

  • No new live inference or latency/semantic-quality qualification was run for this promotion. Synthetic fixtures establish scheduling, accounting and reuse invariants, not semantic equivalence or production speedup.
  • Frozen preparation introduces a preparation/reconciliation boundary and can require extra calls for small or all-deferred inputs. Historical candidate timings are not measurements of these default packet budgets.
  • Existing deployments with removed selectors must clear them. Older-policy curation may need rebuilding.
  • Rollback is a code revert, not a legacy scheduling flag. No automatic merge is requested.

Prepare raw packets in bounded frozen windows and reconcile them serially. Remove legacy serial/speculative scheduling controls, default prior deltas and compact IDs on, and invalidate older curation receipts without changing optional packet budgets or native Decision execution.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Expose lightweight experiment configuration and view detail entry points, preserving existing exports. Use them in the view gateway and client schemas so child startup does not import the corpus, indexing and model dependency graph. Add a real ESM import-boundary regression without increasing readiness deadlines.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hillary-mutisya

Copy link
Copy Markdown
Contributor Author

Fixed the reported Windows CI failure in c8b1f8a.

The browser view child was eagerly loading the memory/index/model runtime through two import paths: experiment configuration and memory-client paging constants. Both now use lightweight service entry points. The existing readiness deadline is unchanged, and an ESM import-boundary regression covers both paths.

Verification:

  • The replacement Windows Node 24 remainder (3) job passed. Its log confirms the original readiness/restart test passed in 2.916 seconds and the new import-boundary test passed.
  • Full workspace build, 1,185 relevant tests, formatting, and all four committed-HEAD quality gates passed locally.
  • At the end of the bounded observation window, no checks were failing. Qualification and Windows smoke/aggregate checks were still pending; this is not a claim that the entire pipeline has finished. Human approval is still required.

@hillary-mutisya
Hillary Mutisya (hillary-mutisya) merged commit 9d0c0c6 into main Nov 13, 2026
109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant