Repository navigation
FIX: Validate replacement templates in SearchReplaceConverter - #4079
Open
电大老baby (HhH666-ux) wants to merge 1 commit into
Open
电大老baby (HhH666-ux) wants to merge 1 commit into
电大老baby (HhH666-ux) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change that validates replacement templates during converter initialization.
No open issues 🎉
What changed in this PR
This PR addresses #4076 by moving replacement-template validation into SearchReplaceConverter construction, so invalid configurations raise a descriptive ValueError before conversion runs.
Changes:
- Validate every replacement template against the compiled regex during initialization.
- Document the new validation and add tests for invalid escapes, missing groups, unknown named groups, and a valid named-group reference.
| File | Description |
|---|---|
tests/unit/converter/test_search_replace_converter.py |
Adds invalid-template regression tests and a valid-template acceptance test. |
pyrit/converter/search_replace_converter.py |
Validates replacement templates during construction and documents the resulting errors. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SearchReplaceConverter.__init__validated the compiled regex pattern but not the templates inreplace. Invalid templates (bad escapes, references to missing groups, unknown named groups) only failed later insideconvert_asyncwith an unhandledre.errororIndexError.replaceagainst the compiled pattern during construction and raise a descriptiveValueError.Fixes #4076