Repository navigation
FIX: Deep-copy seed metadata when converting SeedGroup prompts to messages - #4078
Open
电大老baby (HhH666-ux) wants to merge 1 commit into
Open
电大老baby (HhH666-ux) wants to merge 1 commit into
电大老baby (HhH666-ux) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change isolating seed metadata from message mutations.
No open issues 🎉
What changed in this PR
Fixes #3899 by isolating metadata when SeedGroup converts seed prompts into messages, preventing nested message metadata mutations from affecting source seeds.
Changes:
- Deep-copy seed metadata at the seed-to-message boundary.
- Add a regression test covering history and next-message mutations, unchanged source seeds, and a subsequent history extraction.
| File | Description |
|---|---|
tests/unit/models/test_seed_group.py |
Adds regression coverage for nested metadata isolation. |
pyrit/models/seeds/seed_group.py |
Deep-copies metadata when constructing message pieces. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SeedGroup._prompts_to_messagespassed the seed's metadata mapping directly to the derivedMessagePiece, so nested values were shared between the seed and every extracted message. Mutating a derived message's metadata therefore also changed the source seed and later extractions.Fixes #3899