Repository navigation
FIX: Validate regex replacement templates in SearchReplaceConverter (#4076) - #4077
Open
Vardhman Gupta (Kaap10) wants to merge 1 commit into
Open
Vardhman Gupta (Kaap10) wants to merge 1 commit into
Vardhman Gupta (Kaap10) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
SearchReplaceConverterto validate each replacement template inreplaceagainst the compiled regex pattern during initialization, preventing unhandled runtime crashes (re.error: bad escape,re.error: invalid group reference,IndexError: unknown group name).SearchReplaceConverter.__init__, iterates throughself._replace_listand verifies each template compiles cleanly againstself._compiled_regexby testing substitution on an empty string (self._compiled_regex.sub(item, "")).(re.error, IndexError)and raises a descriptiveValueError(f"Invalid regex replacement template in replace: {e}") from e.Raisessection to document the validation error.\1,\g<name>) as used in1_text_to_text_converters.ipynbandtest_prompt_template_converter.py.test_search_replace_converter.pycovering invalid escape sequences (e.g. Windows file paths with\Uor\u), invalid positional capture groups, unknown named capture groups, and invalid templates in replacement lists, alongside positive regression tests for valid group backreferences.Demonstration
Closes #4076