Repository navigation
MAINT Disable test fail-fast - #3906
Merged
Roman Lutz (romanlutz) merged 1 commit intoNov 4, 2026
Merged
Roman Lutz (romanlutz) merged 1 commit into
Roman Lutz (romanlutz) merged 1 commit into
Conversation
Let unit-test matrix cells finish independently when another cell fails, without changing the matrix or individual check behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change allowing unit-test matrix cells to finish independently after a failure.
No open issues 🎉
What changed in this PR
Disables fail-fast for PyRIT’s unit-test matrix so a failure in one cell, including optional macOS tests, no longer cancels required Windows/Linux cells.
Changes:
- Sets
main-job.strategy.fail-fasttofalse. - Leaves matrix contents, individual failure behavior, test thresholds, and other jobs unchanged.
| File | Description |
|---|---|
.github/workflows/build_and_test.yml |
Allows remaining unit-test matrix cells to finish independently after a failure. |
Review effort: Balanced
Bashir Partovi (bashirpartovi)
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An optional macOS unit-test failure can cancel required Windows/Linux matrix cells, as seen in #3693. Set
main-job.strategy.fail-fasttofalseso the remaining unit-test cells can finish independently. Matrix contents, individual test/check failures, test thresholds, and other jobs remain unchanged.Tests and Documentation
uv run --frozen --no-sync python -m pytest --noconftest -q tests\unit\build_scripts\test_typing_ci_contract.py tests\unit\build_scripts\test_uv_version_contract.py: passed, 13 tests.uv run --frozen --no-sync pre-commit run --files .github\workflows\build_and_test.yml: passed all applicable hooks.origin/main: passed; fail-fast is the booleanfalse, and all other workflow structure is unchanged.git diff --check origin/main...HEAD: passed.Live GitHub CI was not run locally. Documentation and JupyText: N/A, workflow-only change.