Repository navigation
Update loudness note and agent instruction - #99
Merged
Merged
Conversation
Warn researchers about conflicting headset requirements, clarify screen-out submission restrictions, and ignore Prolific bonuses in study setup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 30b0de5e-2392-4118-b128-fd338b444274
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 30b0de5e-2392-4118-b128-fd338b444274
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
P.804 rating instructions can contradict a configured loudspeaker requirement.
1 open finding
What changed in this PR
Adds an optional P.804 loudness warning and expands study-generation guidance and screen-out messaging.
Changes:
- Adds loudness-alert configuration, rendering, conflict warnings, and tests.
- Strengthens screen-out notices across primary templates.
- Updates agent guidance for playback devices and platform-specific bonuses.
| File | Description |
|---|---|
tests/test_master_script.py |
Tests alerts, conflicts, and screen-out notices. |
src/P808Template/P835_template.html |
Adds screen-out notice. |
src/P808Template/P835_personalized_template3.html |
Adds screen-out notice. |
src/P808Template/P808_multi.html |
Adds P.804 instructions and loudness warning. |
src/P808Template/DCR_template.html |
Adds screen-out notice. |
src/P808Template/CCR_template.html |
Adds screen-out notice. |
src/P808Template/ACR_template.html |
Adds screen-out notice. |
src/master_script.py |
Processes alert configuration and warns about conflicts. |
src/configurations/master.cfg |
Documents the new setting. |
requirements-test.txt |
Adds test dependencies. |
.github/agents/create-study.agent.md |
Expands study-creation guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Vishak Gopal (vishakg)
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some hints and configurations for cases that the study include too loud speech, asking the user to use loudspeaker to avoid any potential issue for them.