Repository navigation
ci(hidi): route container deployment jobs to Linux - #914
Merged
Gavin Barron (gavinbarron) merged 2 commits intoOct 14, 2026
Merged
Conversation
Set the explicit 1ES pool on stable and preview container deployment jobs instead of ignored deploy hooks. Preserve the Windows default and disabled preview publishing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d43aad04-6ee4-4dc3-86d2-addcfec2ad11
Use the microsoftgraph (22) service connection for Hidi release artifact attachment. Preserve container deployment pools and all other pipeline settings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d43aad04-6ee4-4dc3-86d2-addcfec2ad11
|
Ramses Sanchez-Hernandez (ramsessanchez)
approved these changes
Oct 14, 2026
|
Approving. One suggestion however, might be a good idea to use our custom Linux pool rather than the shared azure ones, depending on the frequency of use. |
Gavin Barron (gavinbarron)
deleted the
gavinbarron-main-hidi-container-linux-pool
branch
October 14, 2026 20:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Set an explicit deployment-job-level 1ES pool for
publish_containerandpublish_preview_containerin.azure-pipelines/hidi-release.yml:Remove the two ineffective
strategy.runOnce.deploy.pool.vmImageblocks. The inherited default remains Windows for build, signing, and NuGet publishing.Also update the Hidi
GitHubRelease@1task's solegitHubConnectioninput to exactly'microsoftgraph (22)', as requested. The OData library release pipeline and ADO pipeline-definition repository checkout endpoint are not changed.Why
The first production Hidi v2 run selected Windows despite the hook-level Ubuntu selection and failed at
SetUnixFileModebefore credential writing, ACR login, or Docker build. Main has the same configuration. The parent's read-only ADO preview confirmed that the old hook-level selection is not retained as an effective Linux pool in compiled 1ES YAML.The canonical 1ES Custom Release Job contract supports a pool directly on a deployment job. The E+D shared pool documentation documents this existing pool and
image: ubuntu-latest/os: linux; no new pool or resource grant is introduced.The connection follow-up uses the user-requested GitHub release connection for Hidi artifact attachment without changing task input names or release behavior.
Scope and validation
gitHubConnectioninput (one occurrence), restores only its prior value, and proves the full parsed document is otherwise unchanged. Exact textual reconstruction passes for both changes.git diff --checkpasses.true; preview publishing remainsfalse. Versions, dependencies, cache identity, tag gates/floors, ESRP tasks, protected environments, artifact paths, feed authentication, secret permissions/cleanup, and container identity/platforms are unchanged.Actual ADO compiled-YAML preview
Historical proof, not validation of the current head: the parent session completed an actual read-only ADO preview for prior head
7bd6b74ca99f9fa2bca4055520276e9398bb9bcc. Itsverify-container-pool-preview.pyparsed the real server-returnedfinalYamland passed:publish_containerand the disabledpublish_preview_containerresolve toAzure-Pipelines-1ESPT-ExDShared,os: linux,hostArchitecture: amd64, and demandImageOverride -equals ubuntu-latest; the injected 1ES installers selectlinux/resolved.hidiand NuGet deploymentpublish_hidiretainos: windows, demandImageOverride -equals windows-latest, and Windows installer selection.Local historical evidence retained in the parent session (not committed):
Refreshed exact-head preview PASS: the parent session completed a separate actual read-only ADO preview (
previewRun: true) for current head94a39a57c3f0bde5721cbdea88b2a2dc98eebff4, including the connection follow-up. Verification of the real server-returnedfinalYamlconfirms:GitHubRelease@1connection input is exactlymicrosoftgraph (22).hostArchitecture: amd64, demandImageOverride -equals ubuntu-latest, and Linux installer selection. Build and NuGet jobs remain Windows/windows-latest.nuget-org/docker-images-deployenvironments are retained; main preview publishing remains disabled.Read-only service-connection metadata also confirms that existing GitHub connection
microsoftgraph (22)is ready (ID507e403c-ec02-44cf-b7aa-fc0bf0121470); no permission grants were made.Local refreshed evidence retained in the parent session (not committed):
No build/release/rerun, publication, tag change, resource grant, or merge is requested or performed by this change. Existing tagged revisions and compiled runs are not corrected by merging new YAML. A future approved Hidi 3.11.1 release ref must include this accepted fix before tagging; the existing release PR is outside this change's scope.