Repository navigation
ci(hidi): select Linux pool for v2 container deployment - #913
Merged
Gavin Barron (gavinbarron) merged 2 commits intoOct 14, 2026
Merged
Gavin Barron (gavinbarron) merged 2 commits into
Gavin Barron (gavinbarron) merged 2 commits into
Conversation
Set the approved shared-pool Linux image at deployment-job scope instead of the ineffective deployment hook. Preserve the Windows default and all release steps and protections. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 233e3c6f-e303-4c8c-9256-13f42a56db46
Use the user-selected microsoftgraph (22) service connection for the Hidi GitHubRelease input on support/v2. Preserve the Linux deployment pool correction and all other pipeline inputs and steps. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 233e3c6f-e303-4c8c-9256-13f42a56db46
|
Ramses Sanchez-Hernandez (ramsessanchez)
approved these changes
Oct 14, 2026
Ramses Sanchez-Hernandez (ramsessanchez)
left a comment
Ramses Sanchez-Hernandez (ramsessanchez)
left a comment
There was a problem hiding this comment.
Approving with suggestion to use our custom pools.
Gavin Barron (gavinbarron)
deleted the
gavinbarron-v2-hidi-container-linux-pool
branch
October 14, 2026 20:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
hidi-v2.13.1container publish job ran on a Windows agent and failed atSetUnixFileModebefore ACR login or Docker execution. The deployment-hookvmImagedid not survive 1ES template expansion, so the job inherited the pipeline's Windows pool.Azure-Pipelines-1ESPT-ExDShared,image: ubuntu-latest, andos: linuxat the supported deployment-job scope.gitHubConnection: 'microsoftgraph (22)'to the HidiGitHubRelease@1task. The OData library pipeline and ADO repository checkout endpoint are untouched.Validation
Parsed the YAML with the existing PyYAML installation and checked exact text and full-tree structural equivalence against the base for the pool relocation. For the connection follow-up, exact text and full-tree comparison against
2abbb2042189bfc57b7deca483d9d2f1468e165bconfirms all other pipeline configuration and steps are unchanged. AllgitHubConnectioninputs in the Hidi YAML are covered: exactly one, nowmicrosoftgraph (22). No directly related documentation names the old connection. Diff checks pass with the repository's existing CRLF line endings preserved.Refreshed actual Azure DevOps template expansion passed at exact current head
859df3d5f92f0dbfe83501f38cc4ada2564a9cdbusingpreviewRun: true; no run was created. The verifier parsed the server-returnedfinalYamland confirmed:GitHubRelease@1connection,gitHubConnection: 'microsoftgraph (22)'.publish_container: effective poolAzure-Pipelines-1ESPT-ExDShared,os: linux,hostArchitecture: amd64, demandImageOverride -equals ubuntu-latest, and injected 1ES build-tools installer OSlinux.hidibuild andpublish_hidiNuGet/Windows artifact deployment: unchanged Windows pool, demandImageOverride -equals windows-latest, and injected installer OSwindows.nuget-organddocker-images-deployretained.Read-only ADO metadata confirms the existing requested connection is type GitHub,
isReady: true, ID507e403c-ec02-44cf-b7aa-fc0bf0121470. No permission changes were made; readiness does not prove live publishing authorization.Current local parent-session verification report (not a repository artifact):
C:\Users\gavinbarron\.copilot\session-state\c631d217-9378-4cee-8c7e-761043ff3ae5\files\official-release-250228\fixed-v2-859df3d5-preview.verification.json. Compiled preview: alongside it asfixed-v2-859df3d5-preview.yml.Historical preview at previous head
2abbb2042189bfc57b7deca483d9d2f1468e165balso passed the Linux/Windows pool checks before the connection update. Its reports remain alongside the current report asfixed-v2-2abbb204-preview.verification.jsonandfixed-v2-2abbb204-preview.yml; they are historical evidence, not current-head connection proof.The 1ES Custom Release Job contract supports deployment-job-level pools. The canonical E+D Shared Pool documentation explicitly lists
ubuntu-lateston this approved pool and documents thename/image/os: linuxcontract.The previews prove server-side template expansion at their respective heads, not production agent execution or successful publication. No build/release was queued, retried, or merged, and no tag was moved. The immutable old tag still selects its old YAML; rerunning it cannot adopt this fix. Publication requires a future approved corrected release ref/version.