Skip to content

Ensure correct sleep in 'rmw_wait' (backport #344) - #346

Merged
David-LP99 merged 1 commit into
jazzyfrom
mergify/bp/jazzy/pr-344
Oct 6, 2026
Merged

David-LP99 merged 1 commit into
jazzyfrom
mergify/bp/jazzy/pr-344

Conversation

@mergify

@mergify mergify Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Description

Because of truncation and rounding issues, there are some edge cases where rmw_wait() can sleep for less time than the indicated.

Main changes

  • Round non-zero ended nanosecond times up to the next millisecond
  • Since uxr_millis() rounds the clock time down (e.g. 100.9 ms to 100 ms), one more loop iteration is often needed when now == deadline
    This is an automatic backport of pull request Ensure correct sleep in 'rmw_wait' #344 done by Mergify.

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
(cherry picked from commit c3257d4)
@mergify

mergify Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@David-LP99
David-LP99 merged commit cbc4a1e into jazzy Oct 6, 2026
4 checks passed
@David-LP99
David-LP99 deleted the mergify/bp/jazzy/pr-344 branch October 6, 2026 08:45
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.66%. Comparing base (e64d79f) to head (15d2047).
⚠️ Report is 1 commits behind head on jazzy.

Additional details and impacted files
@@           Coverage Diff           @@
##            jazzy     #346   +/-   ##
=======================================
  Coverage   54.66%   54.66%           
=======================================
  Files         101      101           
  Lines        5894     5894           
  Branches      938      927   -11     
=======================================
  Hits         3222     3222           
  Misses       2339     2339           
  Partials      333      333           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants