Repository navigation
docs(design): two-factor authentication screen lab and picks - #1339
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a standalone HTML lab for six two-factor authentication screens, with simulated flows and renders at 1280 and 390 pixels. SELECTION.md records the layouts and representative frame names.
I picked Enrolment A and Step-up A: "ok A both then". The other four screens had one design each. I approved them as drawn on 2026-10-21: "Approve as drawn".
Step-up takes the password and a code, as I decided on 2026-10-20 in #1274, recorded in PR #1334. A1 code alone is not used. Recovery-code entry retains the password field.
The picks comment records the selections. The earlier renders comment shows the lab before review and is superseded by the current frames after review.
No images are committed.
node docs/designs/1275-two-factor/shoot.mjsrenders the full set at 1:1, including night mode for the selected directions. Ata7c636f4bc6130b5ce4ce2069b0a168dd571a91a, all 416 frame checks and interaction assertions passed, including 76 phone throttle frames. The image-pin guard passed both tests.Local review included one full review, then five delta checks at
fbf8f6d4,ef02ab51,794df6e0,956231c6anda7c636f4. The sequence ended clean, with all findings resolved, and covers every commit through the pushed head,a7c636f4bc6130b5ce4ce2069b0a168dd571a91a. Every commit aftera7c636f4only merges main. A narrow review confirmed each merge leaves the branch's own diff byte-identical, and the image-pin tests pass at each one.Docs-impact: none — this lab documents future screens and changes no application text or behaviour.
Closes #1275