Skip to content

using dataclass as build_global for maintability - #323

Merged
sshiraiwa merged 9 commits into
mainfrom
buildglobal_as_dataclass
Nov 10, 2026
Merged

sshiraiwa merged 9 commits into
mainfrom
buildglobal_as_dataclass

Conversation

@sshiraiwa

@sshiraiwa sshiraiwa commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

This PR replaces the build_global, which was defined as a python module, by a dataclass object.
This keeps a new build parameter not added randomly at somewhere else. This PR also fix a couple of issues due to the recent MFEM master.

  1. mfem::CoefficientVector is used before it is defined in coefficient.hpp. (C++ compiler does not require forward declaration, but SWIG needs it ;D)
  2. sidredatacollection.hpp is removed

It also update the Cuda version in CI to 13.4 and consequently added the default cuda_arch of 75.

@sshiraiwa
sshiraiwa merged commit d362b21 into main Nov 10, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant