Skip to content

chore: update react-dropzone dependency - #2413

Open
gjulivan wants to merge 2 commits into
mainfrom
update/react-dropzone
Open

gjulivan wants to merge 2 commits into
mainfrom
update/react-dropzone

Conversation

@gjulivan

Copy link
Copy Markdown
Collaborator

Pull request type


Description

@github-actions

This comment has been minimized.

Comment thread packages/pluggableWidgets/file-uploader-web/CHANGELOG.md Outdated
@gjulivan gjulivan changed the title Chore update react-dropzone dependency chore: update react-dropzone dependency Sep 10, 2026
@gjulivan
gjulivan force-pushed the update/react-dropzone branch from 88e9905 to 1a4d6db Compare September 10, 2026 13:11
@github-actions

This comment has been minimized.

samuelreichert
samuelreichert previously approved these changes Sep 22, 2026
@github-actions

This comment has been minimized.

@gjulivan
gjulivan force-pushed the update/react-dropzone branch from 3ff0a37 to e214085 Compare October 5, 2026 13:14
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

AI Code Review

⚠️ Approved with suggestions — low-severity items only, safe to merge


What was reviewed

File Change
packages/pluggableWidgets/file-uploader-web/CHANGELOG.md Added react-dropzone v14→v20 entry under [Unreleased]
packages/pluggableWidgets/file-uploader-web/package.json react-dropzone bumped ^14.2.3 → ^20.1.1
packages/pluggableWidgets/rich-text-web/CHANGELOG.md Added react-dropzone v14→v20 entry under [Unreleased]
packages/pluggableWidgets/rich-text-web/package.json react-dropzone bumped ^14.4.1 → ^20.1.1
patches/react-dropzone.patch Updated patch targets from v14 dist layout to v20 (dist/index.cjs, dist/index.js, src/utils/index.ts)

Skipped (out of scope): pnpm-lock.yaml

CI checks were still running at review time (E2E, code quality, sigridci) — verify all pass before merge.


Findings

⚠️ Low — Grammar errors in file-uploader-web CHANGELOG entry

File: packages/pluggableWidgets/file-uploader-web/CHANGELOG.md line 19
Note: The sentence reads: "This changes added paste-to-upload, fixing issues on dropped files, and improve accessibility of the drop area." — subject–verb agreement and tense are inconsistent.
Fix:

- We updated the react-dropzone dependency from version 14 to 20. This adds paste-to-upload support, fixes issues with dropped files, and improves accessibility of the drop area.

Positives

  • The patch is cleanly updated to track v20's new dist layout (both dist/index.cjs and dist/index.js plus the TypeScript source src/utils/index.ts), keeping the isExt regex fix applied consistently across all output formats.
  • Both changed packages have CHANGELOG entries for a dependency update that affects user-visible behaviour (paste-to-upload, drop fixes, accessibility).
  • The version range ^20.1.1 is appropriate — caret accepts compatible updates without hard-pinning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants