Skip to content

[closed] accidental overwrite - see #1286 - #1285

Closed
HarshRajSinghania wants to merge 4 commits into
meilisearch:mainfrom
HarshRajSinghania:feat/inline-rule-support
Closed

HarshRajSinghania wants to merge 4 commits into
meilisearch:mainfrom
HarshRajSinghania:feat/inline-rule-support

Conversation

@HarshRajSinghania

Copy link
Copy Markdown

Closes #1284

Summary

The inlineRule parameter for previewing dynamic search rules (Meilisearch v1.55 Enterprise experimental feature) is already accepted by the existing search and multi_search methods because they forward arbitrary optional parameters / query objects into the request body.

This PR adds unit tests that verify the parameter is correctly included in the HTTP request body, and documents the feature in the relevant method docstrings (see note below).

Motivation

Issue #1284 requests support for the new inlineRule parameter on search and multi-search, plus tests and metadata handling. The client already passes through extra fields; formal tests and documentation make the support explicit and maintainable.

Implementation

  • Added tests/test_inline_rule.py with mocked unit tests confirming inlineRule appears in the request body for both Index.search and Client.multi_search.
  • Docstring updates for Index.search and Client.multi_search to mention inlineRule, the Enterprise requirement, and the Meili-Include-Metadata header for condition outcomes.

Testing

  • Unit tests added; they use unittest.mock and do not require a running Meilisearch instance.
  • Full integration tests for the feature would require Meilisearch Enterprise Edition with the dynamicSearchRules experimental feature enabled, which is outside the scope of this contribution.

Notes

The parameter has been accepted by the client since the methods were written to be extensible. This change makes the support explicit, adds regression tests, and improves discoverability via docstrings.

Signed-off-by: Harsh Raj Singhania harshrajsinghania@proton.me

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 09f52137-457e-483d-b06e-01b7eb3799fe
📥 Commits

Reviewing files that changed from the base of the PR and between 506fd06 and c70507f.

📒 Files selected for processing (2)
  • meilisearch/client.py
  • tests/test_inline_rule.py
 ______________________________________________________
< GPU fans at max RPM: ready to blow away regressions. >
 ------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@HarshRajSinghania HarshRajSinghania changed the title Add unit tests and documentation notes for inlineRule support (v1.55 dynamic search rule preview) [closed] accidental overwrite - see #1286 Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Meilisearch v1.55] Add support for dynamic search rule preview

1 participant