Repository navigation
[closed] accidental overwrite - see #1286 - #1285
Closed
HarshRajSinghania wants to merge 4 commits into
Closed
HarshRajSinghania wants to merge 4 commits into
HarshRajSinghania wants to merge 4 commits into
Conversation
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1284
Summary
The
inlineRuleparameter for previewing dynamic search rules (Meilisearch v1.55 Enterprise experimental feature) is already accepted by the existingsearchandmulti_searchmethods because they forward arbitrary optional parameters / query objects into the request body.This PR adds unit tests that verify the parameter is correctly included in the HTTP request body, and documents the feature in the relevant method docstrings (see note below).
Motivation
Issue #1284 requests support for the new
inlineRuleparameter on search and multi-search, plus tests and metadata handling. The client already passes through extra fields; formal tests and documentation make the support explicit and maintainable.Implementation
tests/test_inline_rule.pywith mocked unit tests confirminginlineRuleappears in the request body for bothIndex.searchandClient.multi_search.Index.searchandClient.multi_searchto mentioninlineRule, the Enterprise requirement, and theMeili-Include-Metadataheader for condition outcomes.Testing
unittest.mockand do not require a running Meilisearch instance.dynamicSearchRulesexperimental feature enabled, which is outside the scope of this contribution.Notes
The parameter has been accepted by the client since the methods were written to be extensible. This change makes the support explicit, adds regression tests, and improves discoverability via docstrings.
Signed-off-by: Harsh Raj Singhania harshrajsinghania@proton.me