Repository navigation
Isosphere bench - #21
Merged
Merged
Conversation
Benchmarks setup_neighbors_grid! and setup_neighbors_sort_sweep! on a geodesic icosphere membrane (32000 triangles, 48000 edges, 16002 vertices), added like MEDYAN.jl adds membranes: triangles, edges as triangle lines, and vertices as triangle points, with vertex-own-triangle and shared-vertex edge exclusions. Unlike the ring benchmark, this covers the triangle pair types and a dense, high hit rate system. icosphere_mesh and sphere_slerp are copied from MEDYAN.jl. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HL9ZT4qzp6YYMPdUbM6qoD
- Same-level pass: check the `a` range is empty before loading the `b` range, with `@inbounds` on `_grid_type_range`. - Finer-level pass: inline `_grid_check_finer!` and skip empty cells before the per-cell setup, since most finer cells are empty. - `_filtered_min_radius`: branchless `min_fast` with a separate NaN flag. Ring benchmark 0.793 -> 0.787 ms, isosphere benchmark 34.2 -> 33.4 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HL9ZT4qzp6YYMPdUbM6qoD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor performance improvements and a benchmark for triangle meshes.