Repository navigation
Split grid neighbor search into broad and narrow phases - #19
Merged
Merged
Conversation
The broad phase now only runs the box overlap test on grid entries and buffers candidate `i => j` pairs, already in `NeighborListEdge` order, in a `GridCandidates` buffer. It no longer loads positions, radii, or params. The overlap test is branchless: every checked pair is written at `n + 1` and `n` only advances on a hit. `_grid_make_room!` runs before each run of entries, flushing the buffer through the narrow phase or growing it, so the inner loops never check for room. The narrow phase filters the buffer by distance in place, then applies `filter_pair`, the exclusions, and `mix_params`, and pushes the edges. Replace the pair type tuple with a `GridPairType` struct and delete `_grid_push_edge!`. Ring benchmark, single thread: 1.21 ms -> 0.95 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broad phase now only runs the box overlap test on grid entries and buffers candidate
i => jpairs, already inNeighborListEdgeorder, in aGridCandidatesbuffer. It no longer loads positions, radii, or params. The overlap test is branchless: every checked pair is written atn + 1andnonly advances on a hit._grid_make_room!runs before each run of entries, flushing the buffer through the narrow phase or growing it, so the inner loops never check for room.The narrow phase filters the buffer by distance in place, then applies
filter_pair, the exclusions, andmix_params, and pushes the edges.Ring benchmark, single thread: 1.21 ms -> 0.95 ms.