Repository navigation
Harden the Reader weekly repin reference (qualification pending) - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review fixes
Ops train/contract: https://github.com/mdbase-dev/mdbase-cloud-ops/pull/1335 (
docs/weekly-app-repin.md).publish-sdk-npm.ymlfor SDK,publish-npm.ymlotherwise), and exact release tag ref. Require signed SLSA source commit to equal the production record for SDK and the other packages, exact npm subject/version and SHA-512 digest. Missing or invalid evidence fails closed.CIowns the automatic LAB deployment; a reusable CI call from the production workflow cannot deploy LAB again.gh pr createdirectly for auto-merge instead of immediately querying the index again.Split-pin decision / qualification status
This remains a reference under qualification, not an adopted unattended release. Staging and LAB SDKs remain separately byte-verified environment-specific originals: they embed different trust/origins and are selected without production fallback. The direct protocol original serves manifest-validation tooling; it does not override the SDK's bundled protocol. The ops contract documents the rationale.
Keeping these boundaries is deliberate, not proof of compatibility with the new npm SDK. The existing original-member/provenance checks are not bypassed: production npm intake must pass deliberate compatibility qualification before Reader can be called adopted. Extension version/tag/store publication remains outside this adoption PR. No SDK pin or vendor archive is actually changed by this tooling PR.
Validation
rpnpm test:sdk-repin: 16 tests pass with a frozen install on Node 22.22.0 / pnpm 10.7.0. Covers signer policy, wrong repository/workflow/ref/source/digest/subject, missing provenance, archive tampering, lock tampering, peer preservation, atomic refusal/no-op, narrow triggers and direct PR URL capture.rpnpm lint:code: passes across Reader.git diff --checkpasses. New repin workflow passes actionlint with ShellCheck; CI/deployment workflow expressions pass actionlint (the existing deployment ShellCheck unused-attempt warning is unchanged).PR-only: no merge, no auto-merge on this adoption PR, no publisher/deploy dispatch and no environment/release-record/secret/protection changes. Work remains in the temporary Reader clone, not a
/home/calluma/projectscheckout. GitHub CI on this head must finish before the handoff is called green.