Repository navigation
MCPLGen: state what a stat:sum value of -1 means, not what might have caused it - #66
Merged
Merged
Conversation
… caused it The error message for an input file with stat:sum:initial_ray_count = -1 now only says what -1 means in MCPL (the value is not available), rather than guessing at what happened in the application writing the file. Assisted-by: Claude
Move the definition from ASTNode.icc to ASTNode.cc, where the class template is explicitly instantiated, so it is no longer compiled into each library using it. This is what the TODO in ASTNode.icc asked for, so the TODO is removed. Assisted-by: Claude
tkittel
force-pushed
the
mcplgen-errmsg
branch
from
November 8, 2026 20:26
ee2bbd7 to
a5f5248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCPLGen refuses to normalise weights when the input file has
stat:sum:initial_ray_count = -1. The error message speculated about the
cause (an interrupted run of the application writing the file, or a
partial file). It now only says what -1 means in MCPL: the value is not
available.
Also:
G4MCPLTests app which creates the test input files.
explicit template instantiation from the previous PR.
assisted-by: claude