Repository navigation
Put Markdown field headings below their section - #1810
Open
shadromani wants to merge 1 commit into
Open
shadromani wants to merge 1 commit into
shadromani wants to merge 1 commit into
Conversation
The Markdown output wrote each schema field as an H4 heading. On the minFraud alerts page the table is under an H4 section, so the fields were siblings of that section, not its children. Add a headingLevel parameter to schema-table. It sets the level of the field headings and is 4 by default, which is correct for the tables under H3 sections. The rows read the level from their table. The alerts table sets it to 5. A value outside 2 to 6 stops the build. The HTML output does not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying dev-site with
|
| Latest commit: |
30b8f2d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://073e7851.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://sromani-uhu-3504-field-headi.dev-site-4ua.pages.dev |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UHU-3504: https://linear.app/maxmind/issue/UHU-3504/field-headings-in-the-markdown-api-reference-sit-one-level-below-their
The Markdown output wrote every schema field as an H4 heading. On
/minfraud/alerts/index.mdthe table is under#### Parameters, so the fields were siblings of that section, not its children.schema-tabletakes aheadingLevelparameter for the field headings. The default is 4, which is correct for the tables under H3 sections. A value outside 2 to 6 stops the build.content/minfraud/alerts.mdsetsheadingLevel="5".Verified with a full build on
mainand on this branch: all HTML files are identical. In the Markdown, only the 16 field headings on the alerts page change (####to#####). Lint passes.Follow-up to the review of #1771 (#1771 (comment)). UHU-3616 adds a build check for the heading levels.
🤖 Generated with Claude Code