Skip to content

Fix inverted --default-title command-line flag - #293

Open
123qeew wants to merge 1 commit into
matthewwithanm:developfrom
123qeew:fix/cli-default-title
Open

123qeew wants to merge 1 commit into
matthewwithanm:developfrom
123qeew:fix/cli-default-title

Conversation

@123qeew

@123qeew 123qeew commented Oct 26, 2026

Copy link
Copy Markdown

The CLI adds a fallback link title when --default-title is omitted, and disables it when the flag is supplied. This is the reverse of the option's help text and the documented default_title=False API default.

Use store_true so the flag enables fallback titles. Explicit HTML titles remain unchanged. Four CLI regression cases exercise stdin conversion with and without the flag, including explicit titles.

Validation on Python 3.13.17: the two fallback-title cases fail before the fix; all 87 tests, configured Flake8 checks and README reStructuredText lint pass afterward. Other Python versions were not run.

AI disclosure: found through code inspection and implemented and tested with OpenAI Codex. No production incident or independent human review is claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant