Repository navigation
Conversation
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #32788
What this PR does / why we need it:
metadata_scan()currently exposes the conservative BOOL pruning view as exact user-visible bounds. Consequently, a persisted all-false column reportshex(max) = 01instead of00.Reuse the existing
columnSummaryZoneMapimplementation when constructing column metadata scan results. It derives exact bounds from persisted BOOL column data where metadata is ambiguous, while preserving the historical-data pruning protection introduced by #32725. Returning raw ZoneMap bytes would not be sufficient: historical mixed false/true data can also have a raw false/false summary.*object-statistics shortcut, metadata-only handling for non-BOOL/all-true/uninitialized summaries, and existing visibility/tombstone semantics.Validation on
4.1.6-hotfix@34691aecbb, macOS/arm64, Go 1.26.4, CPU mode:max=false, gottrue.pkg/vm/engine/disttaepackage pass through the repository CGo test wrapper (-count=1).mo-servicebuild successfully in the worktree.optimizer/non_primary_zonemap.sqlpass 111/111 each, with no ignored or abnormal statements and independent database-teardown checks returning 0.The fix does not change the on-disk format or weaken conservative pruning. Ambiguous BOOL summaries may require reading all blocks of the requested column; the existing implementation loads one column block at a time, releases each load, and stops once both Boolean values are observed.
Limits: historical malformed summaries are covered by the existing real-column/private-metadata fixture, not a new old-binary restart exercise. Multi-CN, Linux CI, race stress, full-repository static analysis, and customer-scale performance were not rerun; local single-CN results do not claim those validations passed.