Repository navigation
Conversation
ck89119
marked this pull request as ready for review
November 16, 2026 03:59
ck89119
requested review from
LeftHandCold,
XuPeng-SH,
aptend and
aunjgr
as code owners
November 16, 2026 03:59
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Related to matrixorigin/matrixflow#21333.
What this PR does / why we need it:
Stable non-primary-column
INpredicates can remain row filters without becoming block filters when statistics are unavailable or estimate no pruning benefit. Both incident CTAS queries use such a period predicate.Admit direct-column
INwith a runtime-constant List/Vec RHS through the existing simple ZoneMap filter path. Preserve main's argument validation, volatility/zonemappability checks, residual row filtering, disable hint, and statistics handling. No reader production code, CTAS transaction visibility, or execution topology changes.This is the main-branch counterpart of #32786, adapted to main's current planner and reader contracts.
Validation performed on main with Go 1.27.1:
pkg/sql/planandpkg/vm/engine/readutiltests pass through the repository CGo wrapper.non_primary_zonemapresults, then passed normal comparison twice: 79/79 per run, with teardown verified. Tests cover numeric/string IN, NULLs, duplicates, PREPARE reuse, CTAS, disable-hint controls, overlapping ranges, and actual scan counters.These small fixtures demonstrate correctness and effective pruning, not production-scale latency improvement. Deployment and production acceptance remain pending; this PR does not claim to eliminate the reported waiting time.