Repository navigation
ci: enable PR checks for v4.2.8-hotfix from main - #32716
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
This pull request is merged. |
|
mo-bot review · Commit: Review completed. Read the assessment. |
XuPeng-SH
left a comment
There was a problem hiding this comment.
mo-bot review · mo-bot-local · review
Commit: 49f0e9fd04c5f9905c8ffbd2de2c4bbf3a278000
Assessment: approve
The exact hotfix target extends the existing default-branch admission list and reaches the existing CI Required route. No additional workflow mechanism or permission change is introduced; no actionable defect found.
Model: gpt-6.1-sol / max
Session: 01a1a004-90c3-73b1-acc9-3d4636452003 · slot 0 · generation 0
Validation:
-
All 50 Node CI contracts passed with zero failures/skips: checks/1794581454053687420-2.json and ci-contracts.stdout.log.
-
Parsed baseline/candidate YAML confirms v4.2.8-hotfix is the only semantic addition: checks/1794581448642547568-2.json and workflow-probe.stdout.log.
-
Isolation preflight and final clean-source/discussion/receipt audit passed; audit receipt checks/1794581497246658480-2.json, review-audit.json.
-
Current GitHub platform behavior supports changing the default-branch workflow: official GitHub changelog.
Limitations:
-
Hosted hotfix admission was not triggered locally. It requires merging into main and a new eligible PR event; existing events are not replayed.
-
Disabled post-merge Standalone/TKE workflows and pending broader CI are outside this admission change.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #32713
What this PR does / why we need it:
Pull requests targeting
v4.2.8-hotfixdo not match the default-branch entrypoint's numeric branch filter, soMatrixOne ALL CInever starts. GitHub evaluatespull_request_targetusing the default branch; changing the workflow only on the hotfix branch cannot fix admission.Add the exact hotfix branch to the
mainentrypoint. This supersedes #32714. The existing PR checks andCI Requiredresult then apply on the next eligible hotfix PR event.Validation: actionlint v1.7.12 passes. YAML semantic comparison verifies that the hotfix branch is the only added target and all other workflow behavior is retained.
After merge, synchronize or reopen an existing hotfix PR to trigger validation; earlier events are not replayed. The merged #32704 does not receive CI retroactively.
Post-merge Standalone/TKE callers are manually disabled in GitHub, so this PR makes no claim to restore those workflows. The separate Standalone checkout correction is matrixorigin/CI#477.