Repository navigation
Fix SQL compatibility regressions across aggregates, casts, and prepared DML - #32002
Open
jiangxinmeng1 wants to merge 12 commits into
Open
jiangxinmeng1 wants to merge 12 commits into
jiangxinmeng1 wants to merge 12 commits into
Conversation
jiangxinmeng1
requested review from
XuPeng-SH,
aptend and
aunjgr
as code owners
November 2, 2026 04:19
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
…28485-28230-28119-28024-27340-27332
…28485-28230-28119-28024-27340-27332
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
…view # Conflicts: # pkg/sql/plan/base_binder_test.go # pkg/sql/plan/build_constraint_util.go # pkg/sql/plan/function/func_cast.go # test/distributed/cases/ddl/alter_table_add_drop_primary_key.result # test/distributed/cases/ddl/alter_table_add_drop_primary_key.sql # test/distributed/cases/dtype/binary.result # test/distributed/cases/fulltext/fulltext2.result # test/distributed/cases/git4data/clone/clone_db_table_to_new_db_table.result
jiangxinmeng1
requested a deployment
to
ci
November 16, 2026 07:19 — with
GitHub Actions
In progress
jiangxinmeng1
requested a deployment
to
ci
November 16, 2026 07:19 — with
GitHub Actions
In progress
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Closes #28562, #28485, #28230, #28119, #28024, #27340, #27332.
What this PR does / why we need it:
DEGREESoverflow. Preserve CHAR PAD SPACE provenance throughCOALESCEandIFNULLkeys.MEDIAN(DECIMAL(38,s))to an exactDECIMAL(39,s+1)result and returnSUM(INT)asDECIMAL(32,0), including the single-group reuse path.TIMESTAMPADDunit and preparedDATE_ADD/DATE_SUBcases were already fixed on the earlier base; this PR verifies their status alongside the remaining consolidated fixes.DECIMAL(38,s)widening.SUMnow returns DECIMAL; keep unsafe bounds rejected. Update spill-recovery and dictionary-pipeline tests for the widened result type after merging upstream/main.Validation
pkg/sql/colexec/aggexec,pkg/sql/colexec/group,pkg/sql/plan/function,pkg/sql/plan, andpkg/sql/compile. Focused merge-conflict, grouped-domain boundary, and reviewer-cleanup regressions pass. The previous CI UT failure was an outdated dictionary-pipeline assertion that readSUM(INT32)asint64; it now checks theDECIMAL128result and type.go vetpasses for those packages andpkg/sql/compile. The merge includes upstream/main7fcd9bdff8; the worktree has no unresolved conflicts or whitespace errors.TestDictionaryPipelineAccountLifetimeregression passes with-race; CI is running on the new head.