Repository navigation
Conversation
Open
3 of 7 tasks
XuPeng-SH
marked this pull request as ready for review
November 14, 2026 09:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux release ZIPs omit the dictionaries required by gojieba. The published MatrixOne v4.2.8-hotfix-20261114 Linux/x86_64 ZIP contains no dict directory; inserting the unchanged Chinese FULLTEXT fixture fails with errno 20101, “jieba dictionary not available”. This was found while qualifying matrixorigin/matrixone#32671.
Copy the existing staged dict directory, or the checked-out release source dictionaries, beside mo-service in both Linux architectures. Verify all five required files before archiving/upload. Older release sources without dictionaries keep their prior layout. Reuse the existing workflow validation job; no runner or release job is added. macOS already stages its dictionaries and is unchanged.
Validation: execute the real two Linux staging shell blocks and inspect their real ZIPs (six complete/staged/fallback/old-release layouts and ten missing-file rejection subcases); actionlint 1.7.12 passes. Existing macOS unit tests: ten pass; the unchanged native Apple Silicon test is unselected on Linux. This PR does not publish or replace an existing release asset.