Repository navigation
Version 1.2.0 - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two sites declare the library version, and a grep over the tree before the
change found exactly those two, so nothing is bumped on assumption:
Both now read 1.2.0. There is no changelog here recording 1.1.2 as a past
version, so no history line needed leaving alone, and the one other version
number in the tree is the format version 1.1 in STANDARD.md, which names the
wire rather than a library release and does not move. The release pointer in
the README is the releases page since #8, so it cannot go stale and needs no
edit either.
The third component does not carry this. Before #10 a reader required its
backing array to be allocated with eight bytes of slack past the packet, and
calling code had to know that; the precondition is now lifted, so a buffer
sized exactly to the packet reads to its last bit. Code that could not be
written against 1.1.2 can be written against this, which makes it a new
capability rather than a fix, and the minor component is where a capability
goes. 1.1.3 would say the library does the same things it did before, and that
is not true.
So the release carries #10: BitReader and ReadStream accept any array size,
reading the final bytes through a sixteen-byte tail when the array is tight,
with one branch on the hot path and no allocation.
On tests, this bench has no pinned toolchain. The Makefile invokes
dist/jdk-21.0.12.1 by absolute path and that directory is gitignored and
absent from a fresh clone, so the suite ran against the JDK that is here,
Homebrew OpenJDK 27, passed in the same way CI passes it, through JDK_HOME.
Both shapes are green: make test reports 462 tests and 4359 checks with none
failed, and make test-release reports 461 tests and 4354 checks with none
failed. That is a newer compiler and runtime than the pinned 21, so CI on
Temurin 21 is still the result that counts, along with the interop and
spec-sync jobs, which need the network and the C++ reference and did not run
here. Nothing in the suite asserts on the VERSION constant.
No tag and no release from this branch.