Repository navigation
A deck read back carries no title it never had, and the slides example says what it needs - #49
Merged
Merged
Conversation
The rule for the title was in the frontmatter's docblock and again in the method that decides it, the two defaults each said the same thing twice, and the tests' comments repeated what the names of the tests already say. What is left is what the code cannot say: that PHPPresentation's own defaults are not a title or a name somebody wrote, and that the frontmatter is the first slide's.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes, both from the review of the 0.4.0 release.
A deck read back into Markdown carries no title it never had
PowerPointToMarkdownwrotedc:titleinto the deck's frontmatter as it stood. PHPPresentation gives every deck the titleUntitled Presentation, and that is the library's own default rather than a title somebody wrote — so a deck without a title came back with one, and drawing that Markdown again put a title placeholder and the words "Untitled Presentation" on a slide that never had a title.The frontmatter now carries a title where the deck has one: the package's own title, or the first slide's where the package carries none. The frontmatter is the first slide's, and a
title:in it is that slide's title, so a deck whose title is on its slide and nowhere else keeps it — and a deck with no title at all comes back with notitle:line.It is the first slide's title and not a later one's, the way it is in the other direction: a
title:in the first slide's frontmatter is that slide's title and wins over its own heading. So a deck whose second slide has a title and whose first does not gains no title.The round trip is a round trip now.
deck.md → deck.pptx → deck.md → deck.pptxdraws the same slide every time:Untitled Presentation/OneText.One/Text.The slides example says what it needs
examples/build.phprequired../vendor/autoload.phpoutright. Themdwordskill bundle carries this half's gallery asexamples/slides/and ships novendor/, so the build died with a PHP fatal error that said nothing about what was missing.It says what the build needs and stops, the way
markdown-word's ownexamples/build.phphas said it for a while — the two halves ship side by side in one bundle, so they fail the same way:No release is cut here; the
## [Unreleased]section of the changelog carries both.